feat(launchpad): Add backend, service, indexer, db #1432
Conversation
✅ Deploy Preview for teritori-dapp ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for gno-dapp ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
… in proto message
…-dapp into feat-launchpad-backend
WaDadidou
requested review from
n0izn0iz,
hthieu1110,
omarsy,
Villaquiranm,
clegirar and
MikaelVallenet
| repeated LaunchpadProject projects = 1; | ||
| } | ||
|
|
||
| message LaunchpadProjectsRequest { |
There was a problem hiding this comment.
Should not just add a optional creator id to refactor the same request above with just creator_id as addition?
| string sender = 1; | ||
| string network_id = 2; | ||
| string project_id = 3; | ||
| string proposal_id = 4; |
There was a problem hiding this comment.
why is there a proposal id, if you want to create a proposal to approve a project request
or maybe i don't understand the purpose of this message
There was a problem hiding this comment.
if this is about approving a project request what about: ApproveProjectRequestProposal
|
|
||
| func (h *Handler) handleExecuteSubmitCollection(e *Message, execMsg *wasmtypes.MsgExecuteContract) error { | ||
| var jsonData map[string]map[string]interface{} | ||
| if err := json.Unmarshal(execMsg.Msg.Bytes(), &jsonData); err != nil { |
There was a problem hiding this comment.
would be nice to unmarshal into a type ? instead of using jsonData["key"] after isn't ?
| return errors.Wrap(err, "failed to unmarshal json") | ||
| } | ||
|
|
||
| collectionId := jsonData["update_merkle_root"]["collection_id"] |
|
|
||
| switch provider { | ||
| case Pinata: | ||
| url = "https://api.pinata.cloud/psa" |
There was a problem hiding this comment.
i like to have const data like this on top of the file in a const so we can reuse-it and modify it easily from one place.I know it's used juste one time here, just personal preference, feel free to do what you feel is right
Extracted from #1024
Most work was done by @hthieu1110
It adds: