Fix sign check by verifying timestamp #111
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR enhances security by adding timestamp validation to cluster signature verification. The change ensures that signatures are rejected if they are older than 5 minutes, preventing replay attacks.
- Replaces
check_sign_without_timewithcheck_signto include timestamp validation - Adds automatic rejection of signatures older than 5 minutes
| @@ -261,7 +261,7 @@ async def access_log_middleware(request: fastapi.Request, call_next): | |||
|
|
|||
| def get_cluster_from_sign(hash: str, s: str, e: str) -> Optional[str]: | |||
| for cluster in clusters.clusters: | |||
| if check_sign_without_time(hash, cluster._token._secret, s, e): | |||
| if check_sign(hash, cluster._token._secret, s, e): | |||
There was a problem hiding this comment.
The timestamp validation logic in check_sign uses time.time() - 300 < int(e, 36) which could allow future timestamps to be valid. Consider using abs(time.time() - int(e, 36)) < 300 to reject both old and future timestamps, or add an explicit check that int(e, 36) <= time.time() to prevent acceptance of future-dated signatures.
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
check_signTesting
python -m py_compile $(git ls-files '*.py')https://chatgpt.com/codex/tasks/task_e_6880ab1b8430832b90e5351ceeeecd77