-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add locational voice chat range cut-off setting #1503
Conversation
Not sure if using 0 as a special value to disable the feature is idiomatic or if I should add a bool that enables/disables the cut-off being active. |
As for the motivation for this feature: by default, you can basically still hear every player from anywhere on the map, they just get very quiet at some point which is probably not what most people want. |
Does this also account for the "local origin" issue where anyone standing near 0,0,0 will be able to hear conversations at a much higher volume due to the speaking player being in the PAS but not the PVS? |
Sorry, I don't know anything about that issue (didn't even know that was a thing). Would that affect distance calculations? |
It is more like it is a problem that frequently crops up with distance-cutoff because the issue becomes more apparent when the voice range is relatively small but the map is dense, I'm surprised you haven't had it come up. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very good and i think 0 is fine for disabled 🙌
Thank you so much for improving this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me :)
using 0 to turn this is off is a good choice
#1491