Hook: Added hook "TTT2PlayDeathScream" for deathscreams #1668
Conversation
|
Woohoo, awesome to see this making it in!
|
|
(any feedback appreciated) |
Changed isSilent to be a extra param in the hook itself. It will only be used by the GM hook if no other hook returns something.
|
Latest commit changed to how isSilent should be handled instead, as per suggestion. |
|
Anything else for this to get merged? Just so it does not stale :P |
|
dangit, ofc I missed that. Should be resolved now. |
Style is still complaining :D |
I might just be retarded.. But I actually don't get why it's complaining o.O? |
|
Ok.. ffs.. Took me 10 years now to know how the freak this style check works.. Well, better now than never. |
FYI, if you install stylua in VSCode it autodects the config file in the repo and does everything for you everytime you save the file |
Ohhhhhhh wait actually? Damn, will do that rn. |
Yes! I wasn't a fan of it initially, but Histalek was right, it is really nice. If you have any issues with it, ask him, he knows how to fix it :D |
This hook allows to change the sound of the deathscream or cancel it outright.
Maybe I'm mistaken but I thought the table approach would be the most appropriate one here. Please correct me if not.
Changelog will follow when this is done.