TargetID: Make ttt_idenfity_body_woconfirm replicated; move and clean up additional ConVars surrounding corpses/ragdolls

CHANGELOG.md

@@ -24,6 +24,7 @@ All notable changes to TTT2 will be documented here. Inspired by [keep a changel
 - Fixed console error when dropping ammo for weapons with no AmmoEnt (by @MrXonte)
 - Fixed client error for a not fully initialized client (by @Histalek)
 - Fixed the targetID corpse hint not respecting `ttt_identify_body_woconfirm` (by @Histalek)
+- Fixed networked values for `ttt_identify_body_woconfirm` and `ttt2_confirm_team` not being updated properly when changed (by @Wryyyong)
 - Fixed the beacon not being properly translated when placed (by @Histalek)
 
 ### Changed

gamemodes/terrortown/gamemode/server/sv_main.lua

@@ -132,7 +132,7 @@ local map_switch_delay = CreateConVar(
 
 ---
 -- @realm server
-CreateConVar(
+local identify_body_woconfirm = CreateConVar(
     "ttt_identify_body_woconfirm",
     "1",
     { FCVAR_NOTIFY, FCVAR_ARCHIVE },
@@ -505,7 +505,8 @@ function GM:SyncGlobals()
         )
     end
 
-    SetGlobalBool("ttt2_confirm_team", confirm_team:GetBool())
+    SetGlobalBool(identify_body_woconfirm:GetName(), identify_body_woconfirm:GetBool())
+    SetGlobalBool(confirm_team:GetName(), confirm_team:GetBool())
 
     ---
     -- @realm server
@@ -520,6 +521,14 @@ cvars.AddChangeCallback(idle_enabled:GetName(), function(cv, old, new)
     SetGlobalBool(idle_enabled:GetName(), tobool(tonumber(new)))
 end)
 
+cvars.AddChangeCallback(identify_body_woconfirm:GetName(), function(cv, old, new)
+    SetGlobalBool(identify_body_woconfirm:GetName(), tobool(tonumber(new)))
+end)
+
+cvars.AddChangeCallback(confirm_team:GetName(), function(cv, old, new)
+    SetGlobalBool(confirm_team:GetName(), tobool(tonumber(new)))
+end)
+
 ---
 -- This @{function} is used to load the shop equipments
 -- @realm server

lua/ttt2/libraries/targetid.lua

@@ -562,7 +562,7 @@ function targetid.HUDDrawTargetIDRagdolls(tData)
             tData:AddDescriptionLine(TryT("corpse_hint_inspect_limited_details"))
         elseif
             bodysearch.GetInspectConfirmMode() == 0
-            and not GetConVar("ttt_identify_body_woconfirm"):GetBool()
+            and not GetGlobalBool("ttt_identify_body_woconfirm", true)
         then
             tData:SetSubtitle(ParT("corpse_hint_without_confirm", key_params))
         else