-
-
Notifications
You must be signed in to change notification settings - Fork 365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEAT] Allow returning anything in a validator, not just a string #1104
Merged
+11,217
−10,814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
View your CI Pipeline Execution ↗ for commit b6de203.
☁️ Nx Cloud last updated this comment at |
This was referenced Jan 9, 2025
This was referenced Jan 10, 2025
TODO: Refactor form adapters
…TanStack/form into return-anything-not-just-string
…TanStack/form into return-anything-not-just-string
2 tasks
# Conflicts: # docs/reference/functions/mergeform.md # examples/angular/valibot/package.json # examples/angular/yup/package.json # examples/angular/zod/package.json # examples/react/query-integration/package.json # examples/react/standard-schema/package.json # examples/react/tanstack-start/package.json # examples/react/ui-libraries/package.json # examples/react/valibot/package.json # examples/react/yup/package.json # examples/react/zod/package.json # examples/solid/array/package.json # examples/solid/simple/package.json # examples/solid/valibot/package.json # examples/solid/yup/package.json # examples/solid/zod/package.json # examples/vue/array/package.json # examples/vue/simple/package.json # examples/vue/valibot/package.json # examples/vue/yup/package.json # examples/vue/zod/package.json # packages/valibot-form-adapter/package.json # packages/yup-form-adapter/package.json # packages/zod-form-adapter/package.json # pnpm-lock.yaml
Balastrong
approved these changes
Feb 21, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's do it! 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows you to return non-string values from validators:
In addition, it also enforces type safety on the returned value on both
errorMap
and theerrors
array:Breaking Changes
validatorAdapter
s (packages, code, and props alike)Yup
is no longer supported until this community PR is mergedform.errors
is nowRecord<string, StandardSchemaIssue[]>
field.errors
is nowStandardSchemaIssue[]
(flattened)TODO
error
array handlingFuture work