-
-
Notifications
You must be signed in to change notification settings - Fork 450
fix(form-core): fix form.resetField() ignoring nested fields #1497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
View your CI Pipeline Execution ↗ for commit d1d007a.
☁️ Nx Cloud last updated this comment at |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1497 +/- ##
=======================================
Coverage 89.13% 89.13%
=======================================
Files 31 31
Lines 1417 1417
Branches 362 362
=======================================
Hits 1263 1263
Misses 137 137
Partials 17 17 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Thats a good catch, and good job on the PR. Do you mind if I throw on a type test? |
Go ahead! |
5ba4ca9
to
d1d007a
Compare
Closes #1496
See the issue for more details.
The main issue is that the field name was assumed to be a shallow
keyof TFormData
when it is actuallyDeepKeys<TFormData>
. TypeScript didn't complain because there was anas
assertion.This PR implements the unit test provided in the issue and fixes it.