Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/stale time on query attempt 2 #8360

Draft
wants to merge 17 commits into
base: main
Choose a base branch
from
Draft

Feature/stale time on query attempt 2 #8360

wants to merge 17 commits into from
+115 −78

Conversation

TkDodo
Copy link
Collaborator

@TkDodo TkDodo commented Nov 27, 2024

No description provided.

@TkDodo
feat: move stale timers to query, but keep staleTime on observers
2e96d61
@TkDodo
Merge branch 'main' into feature/staleTime-on-query-attempt-2
6501d46
@TkDodo
fix: use a dedicated stale action
eea79ac
@TkDodo
test: we now receive more "stale events"
4b8eaae
@TkDodo
Merge branch 'main' into feature/staleTime-on-query-attempt-2
daecbd1
@TkDodo
fix: make sure disabled observers don't fetch on mount
9f8a95f
@TkDodo
refactor: do not dispatch a pseudo stale action
c115a47 
instead, just notify observers and cache with a dedicated #notify function
@TkDodo
test: this assertion seems to be (more) correct
6c1458c
@TkDodo
test: fix two tests
ef83952
@TkDodo
fix: check detached observer staleTimes separately
d557cb7
@TkDodo
fix: bring back proper observer based stale check
709fe12 
that includes the current observer's check for isStaleByTime (as it might not be attached yet)
@TkDodo
Merge branch 'main' into feature/staleTime-on-query-attempt-2
2c453b4
@TkDodo
perf: bail out if staleTime stays the same
e0c2e82
@TkDodo
chore: fix
2346fc8
@TkDodo
fix: force a new stale timer if we got new data
861e77d
@TkDodo
Revert "Auxiliary commit to revert individual files from e0c2e82"
f8cd93e 
This reverts commit 461f3017a624f489f024007c602fe8cd38a24929.
@TkDodo
fix: move updateStaleTimer to addObserver / removeObserver
6953297
@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Nov 27, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 6953297. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

🟥 Failed Commands
nx affected --targets=test:sherif,test:knip,test:eslint,test:lib,test:types,test:build,build --parallel=3
✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Nov 27, 2024

Open in Stackblitz

More templates

@tanstack/angular-query-devtools-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-devtools-experimental@8360

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@8360

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@8360

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@8360

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@8360

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@8360

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@8360

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@8360

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@8360

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@8360

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@8360

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@8360

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@8360

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@8360

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@8360

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@8360

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@8360

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@8360

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@8360

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@8360

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@8360

commit: 6953297

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
package: query-core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@TkDodo