types(vue-query): add shallow support to QueryClientConfig
#8692
+44
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
View your CI Pipeline Execution ↗ for commit 1e4efea.
☁️ Nx Cloud last updated this comment at |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8692 +/- ##
===========================================
+ Coverage 46.28% 71.01% +24.73%
===========================================
Files 199 19 -180
Lines 7549 483 -7066
Branches 1727 136 -1591
===========================================
- Hits 3494 343 -3151
+ Misses 3675 110 -3565
+ Partials 380 30 -350
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many thanks to #7733 for the great work. With that PR, we can now enable
shallowReactiveglobally usingshallow: true. However, the current type definitions might lead to confusion, making it seem like this option cannot be set globally.This PR adds the relevant types and JSDoc to help clarify this behavior and reduce potential misunderstandings for users.