Skip to content

fix(vue-query): move queryOptions and useQuery function overloads #9088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
88 changes: 88 additions & 0 deletions packages/vue-query/src/__tests__/queryOptions.test-d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -122,4 +122,92 @@ describe('queryOptions', () => {
expectTypeOf(data).toEqualTypeOf<Promise<void>>()
expectTypeOf(data2).toEqualTypeOf<Promise<number>>()
})

it('TData should always be defined when initialData is provided as a function which ALWAYS returns the data', () => {
const { data } = reactive(
useQuery(
queryOptions({
queryKey: ['key'],
queryFn: () => {
return {
wow: true,
}
},
initialData: () => ({
wow: true,
}),
}),
),
)

expectTypeOf(data).toEqualTypeOf<{ wow: boolean }>()
})

it('TData should have undefined in the union when initialData is NOT provided', () => {
const { data } = reactive(
useQuery(
queryOptions({
queryKey: ['key'],
queryFn: () => {
return {
wow: true,
}
},
}),
),
)

expectTypeOf(data).toEqualTypeOf<{ wow: boolean } | undefined>()
})

it('TData should have undefined in the union when initialData is provided as a function which can return undefined', () => {
const { data } = reactive(
useQuery(
queryOptions({
queryKey: ['key'],
queryFn: () => {
return {
wow: true,
}
},
initialData: () => undefined as { wow: boolean } | undefined,
}),
),
)

expectTypeOf(data).toEqualTypeOf<{ wow: boolean } | undefined>()
})

it('TData should be narrowed after an isSuccess check when initialData is provided as a function which can return undefined', () => {
const { data, isSuccess } = reactive(
useQuery(
queryOptions({
queryKey: ['key'],
queryFn: () => {
return {
wow: true,
}
},
initialData: () => undefined as { wow: boolean } | undefined,
}),
),
)

if (isSuccess) {
expectTypeOf(data).toEqualTypeOf<{ wow: boolean }>()
}
})

it('data should not have undefined when initialData is provided', () => {
const { data } = reactive(
useQuery(
queryOptions({
queryKey: ['query-key'],
initialData: 42,
}),
),
)

expectTypeOf(data).toEqualTypeOf<number>()
})
})
11 changes: 11 additions & 0 deletions packages/vue-query/src/__tests__/useQuery.test-d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,17 @@ describe('useQuery', () => {
expectTypeOf(data).toEqualTypeOf<{ wow: boolean }>()
}
})

it('data should not have undefined when initialData is provided', () => {
const { data } = reactive(
useQuery({
queryKey: ['query-key'],
initialData: 42,
}),
)

expectTypeOf(data).toEqualTypeOf<number>()
})
})

describe('custom composable', () => {
Expand Down
8 changes: 4 additions & 4 deletions packages/vue-query/src/queryOptions.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@ export function queryOptions<
TData = TQueryFnData,
TQueryKey extends QueryKey = QueryKey,
>(
options: UndefinedInitialQueryOptions<TQueryFnData, TError, TData, TQueryKey>,
): UndefinedInitialQueryOptions<TQueryFnData, TError, TData, TQueryKey> & {
options: DefinedInitialQueryOptions<TQueryFnData, TError, TData, TQueryKey>,
): DefinedInitialQueryOptions<TQueryFnData, TError, TData, TQueryKey> & {
queryKey: DataTag<TQueryKey, TQueryFnData, TError>
}

Expand All @@ -21,8 +21,8 @@ export function queryOptions<
TData = TQueryFnData,
TQueryKey extends QueryKey = QueryKey,
>(
options: DefinedInitialQueryOptions<TQueryFnData, TError, TData, TQueryKey>,
): DefinedInitialQueryOptions<TQueryFnData, TError, TData, TQueryKey> & {
options: UndefinedInitialQueryOptions<TQueryFnData, TError, TData, TQueryKey>,
): UndefinedInitialQueryOptions<TQueryFnData, TError, TData, TQueryKey> & {
queryKey: DataTag<TQueryKey, TQueryFnData, TError>
}

Expand Down
14 changes: 9 additions & 5 deletions packages/vue-query/src/useQuery.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import { useBaseQuery } from './useBaseQuery'
import type {
DefaultError,
DefinedQueryObserverResult,
InitialDataFunction,
QueryKey,
QueryObserverOptions,
} from '@tanstack/query-core'
Expand Down Expand Up @@ -64,7 +65,10 @@ export type UndefinedInitialQueryOptions<
TData = TQueryFnData,
TQueryKey extends QueryKey = QueryKey,
> = UseQueryOptions<TQueryFnData, TError, TData, TQueryFnData, TQueryKey> & {
initialData?: undefined | (() => undefined)
initialData?:
| undefined
| InitialDataFunction<NonUndefinedGuard<TQueryFnData>>
| NonUndefinedGuard<TQueryFnData>
}

export type DefinedInitialQueryOptions<
Expand Down Expand Up @@ -95,19 +99,19 @@ export function useQuery<
TData = TQueryFnData,
TQueryKey extends QueryKey = QueryKey,
>(
options: UndefinedInitialQueryOptions<TQueryFnData, TError, TData, TQueryKey>,
options: DefinedInitialQueryOptions<TQueryFnData, TError, TData, TQueryKey>,
queryClient?: QueryClient,
): UseQueryReturnType<TData, TError>
): UseQueryDefinedReturnType<TData, TError>

export function useQuery<
TQueryFnData = unknown,
TError = DefaultError,
TData = TQueryFnData,
TQueryKey extends QueryKey = QueryKey,
>(
options: DefinedInitialQueryOptions<TQueryFnData, TError, TData, TQueryKey>,
options: UndefinedInitialQueryOptions<TQueryFnData, TError, TData, TQueryKey>,
queryClient?: QueryClient,
): UseQueryDefinedReturnType<TData, TError>
): UseQueryReturnType<TData, TError>

export function useQuery<
TQueryFnData = unknown,
Expand Down
Loading