fix(svelte-query): state_unsafe_mutation error with useIs...
#9493
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…afe_mutation fixes useIsFetching and useIsMutating in svelte 5 adapter
hmnd
force-pushed
the
fix/svelte-query-isfetching
branch
from
dd04604 to
e22d61e
Compare
|
View your CI Pipeline Execution ↗ for commit 4f57fd5
☁️ Nx Cloud last updated this comment at |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the bug reported by @frederikhors here.
I thoroughly dug into this issue until I found calls to
ObserverandMutataionOBserverwere wrapped in a$derived(...)in order to make them reactive to the passed in client. This was resulting in unsafe mutation errors, and there was already an$effect.pre(...)used for updating options when they changed, so aside from the client reactivity, the$derivedwasn't necessary.To support reactivity for
queryClient, the observer is now a$stateand is reassigned whenever the client changes.The
useIsFetchinganduseIsMutatingtests were previously passing because they used aQueryClientlocal to the component, rather than one from context. I've updated the tests to use a provider instead, in order to properly repro this issue.