test(svelte-query/{queryOptions,infiniteQueryOptions}): add 'eslint-disable' for 'vitest/expect-expect' #9496
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…isable' for 'vitest/expect-expect'
|
View your CI Pipeline Execution ↗ for commit 914f347
☁️ Nx Cloud last updated this comment at |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9496 +/- ##
===========================================
+ Coverage 45.30% 89.20% +43.89%
===========================================
Files 208 18 -190
Lines 8283 176 -8107
Branches 1863 31 -1832
===========================================
- Hits 3753 157 -3596
+ Misses 4085 18 -4067
+ Partials 445 1 -444
🚀 New features to boost your workflow:
|
manudeli
reviewed
Jul 26, 2025
| @@ -5,6 +5,7 @@ import { createInfiniteQuery, infiniteQueryOptions } from '../../src/index.js' | |||
| import type { InfiniteData } from '@tanstack/query-core' | |||
|
|
|||
| describe('queryOptions', () => { | |||
| // eslint-disable-next-line vitest/expect-expect | |||
There was a problem hiding this comment.
assertType of vitest could be better for this case
Could you check that?
There was a problem hiding this comment.
test('Should not allow excess properties', () => {
const options = infiniteQueryOptions({
queryKey: ['key'],
queryFn: () => Promise.resolve('data'),
getNextPageParam: () => 1,
initialPageParam: 1,
// @ts-expect-error this is a good error, because stallTime does not exist!
stallTime: 1000,
})
expectTypeOf(options).toEqualTypeOf<
CreateInfiniteQueryOptions<
string,
Error,
InfiniteData<string, unknown>,
Array<string>,
number
>
>()
})How about this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.