-
-
Notifications
You must be signed in to change notification settings - Fork 664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(react-router): ensure links and scripts are available on routes created with createRoute
#2854
base: main
Are you sure you want to change the base?
fix(react-router): ensure links and scripts are available on routes created with createRoute
#2854
Conversation
…with createFileRoute work routes created with createRoute did not
we need a test for this |
☁️ Nx Cloud ReportCI is running/has finished running commands for commit ae4c28c. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 2 targetsSent with 💌 from NxCloud. |
createRoute
createRoute
@@ -2528,6 +2528,8 @@ export class Router< | |||
loaderData, | |||
}) | |||
const meta = headFnContent?.meta | |||
const links = headFnContent?.links |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand why this worked in createFileRoute
but not in createRoute
. can you explain this please?
We found that creating a route with
createRoute
would not expose links and scripts where as when creating a route withcreateFileRoute
the link and script properties would exist as expected. We expect the behaviour to be the same across the board.