fix(start): returning `null` from server functions #3048

alakhpc · 2024-12-20T06:23:33Z

Fixes #2776, pass through null returns from serverfns

schiller-manuel · 2024-12-20T10:52:45Z

can you please cherry-pick this on top? #2778

…-return

nx-cloud · 2024-12-21T07:18:01Z

View your CI Pipeline Execution ↗ for commit 9f7645d.

Command	Status	Duration	Result
`nx affected --targets=test:eslint,test:unit,tes...`	✅ Succeeded	4m 38s	View ↗
`nx run-many --target=build --exclude=examples/*...`	✅ Succeeded	43s	View ↗

☁️ Nx Cloud last updated this comment at 2024-12-22 19:13:02 UTC

pkg-pr-new · 2024-12-21T07:19:18Z

Open in Stackblitz

More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/@tanstack/arktype-adapter@3048

@tanstack/create-router

npm i https://pkg.pr.new/@tanstack/create-router@3048

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@3048

@tanstack/history

npm i https://pkg.pr.new/@tanstack/history@3048

@tanstack/create-start

npm i https://pkg.pr.new/@tanstack/create-start@3048

@tanstack/react-cross-context

npm i https://pkg.pr.new/@tanstack/react-cross-context@3048

@tanstack/react-router

npm i https://pkg.pr.new/@tanstack/react-router@3048

@tanstack/react-router-with-query

npm i https://pkg.pr.new/@tanstack/react-router-with-query@3048

@tanstack/router-cli

npm i https://pkg.pr.new/@tanstack/router-cli@3048

@tanstack/router-devtools

npm i https://pkg.pr.new/@tanstack/router-devtools@3048

@tanstack/router-generator

npm i https://pkg.pr.new/@tanstack/router-generator@3048

@tanstack/router-plugin

npm i https://pkg.pr.new/@tanstack/router-plugin@3048

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/@tanstack/router-vite-plugin@3048

@tanstack/start

npm i https://pkg.pr.new/@tanstack/start@3048

@tanstack/start-vite-plugin

npm i https://pkg.pr.new/@tanstack/start-vite-plugin@3048

@tanstack/valibot-adapter

npm i https://pkg.pr.new/@tanstack/valibot-adapter@3048

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/@tanstack/virtual-file-routes@3048

@tanstack/zod-adapter

npm i https://pkg.pr.new/@tanstack/zod-adapter@3048

commit: 9f7645d

e2e/start/basic/app/routes/-server-fns/allow-fn-return-null.tsx

packages/start/src/client/createServerFn.ts

SeanCassiere · 2024-12-22T20:50:32Z

@alakhpc thank you for contributing this fix 🎉

Co-authored-by: SeanCassiere <[email protected]>

* checkpoint * checkpoint * cleanup * checkpoint * client babel now works, runtime and rpc injection * fix: dont touch anything outside of the function * server functions now import a tsr-serverfn-split file version * checkpoint * checkpoint * fis tests * It's working!!! * move serverFnFetcher to start client * fix: no extra context, throw errors from middleware * docs: add custom link example for mantine (#3033) * ci: apply automated fixes * fix(react-router): make sure full matches are passed into route functions (#3039) * release: v1.91.3 * docs: minor typo in code-based-routing.md (#3043) * feat(start): create-start cli (#2920) * create start cli * update lockfile * ci: apply automated fixes --------- Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> * docs: Minor typo in middleware.md (#3042) * release: v1.92.0 * refactor(react-router): expose `scrollBehavior` on the `ScrollRestoration` component (#3053) Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> Co-authored-by: Sean Cassiere <[email protected]> * release: v1.92.1 * fix(start): returning `null` from server functions (#3048) Co-authored-by: SeanCassiere <[email protected]> * release: v1.92.2 * fix: allow serverFn errors to also have context (#3037) * fix: allow serverFn errors to also have context * fix: allow errors, undefined from server functions * remove logs * fix: transformer and tests * ci: apply automated fixes * no logs * fix conficts --------- Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> * release: v1.92.3 * move directive plugin to own package * fixes, tests * suggested fixes from sean * fix tests * fix: import specifier * fix: dev imports * fix: simpler config, better logging, more reliable plugin coordination * fix: update test snapshots * fix: non-split directives, clean up compilers, logging, and * fix: production server fn builds * feat(start): explicitly enable and disable route generation * fix: $fetch during dev * ci: apply automated fixes * Update comparison.md * docs: remove duplicate word (#3125) * docs: remove duplicate word * docs: correct typo in learn-the-basics.md * chore: add skipLibCheck to examples (#3134) * docs: Typo issue - getParent Does not Exists in type RouteOptions (#3131) * docs: Fix notFound import (#3133) * docs: fix dead link and typo in guide (#3136) Typo introduced in #2963. * fix(react-router): separate internal and user provided history state (#3119) * release: v1.95.2 * fix(router-generator) use explicit routes export by default (#3109) Co-authored-by: Vladimir Panov <[email protected]> * fix(start): serialize `FormData` for server function input (#3138) * release: v1.95.3 * test(react-router): check `FormData` serialization in transformer (#3139) * docs(router): missing character in code-splitting guide (#3143) * fix(create-start): readme changes and little fixes (#3142) * release: v1.95.4 * fix(start): preserve multiple values for same key in `FormData` serialization (#3140) Co-authored-by: SeanCassiere <[email protected]> * release: v1.95.5 * docs(migrate): correct typo in migration documentation (#3153) * docs(start): fix `FormData` server functions examples (#3062) Co-authored-by: Sean Cassiere <[email protected]> * docs(router): require the use of React's `createRoot` function (#3151) Co-authored-by: Sean Cassiere <[email protected]> * fix: order of injected scripts (#3158) Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> * release: v1.95.6 * perf(start): reduce instantiations of server fn and middleware (again) (#3168) * perf: reduce instantiations of server fns * perf(start): reduce instantiations of middleware * release: v1.95.7 * fix imports * fix: build test --------- Co-authored-by: Youssef Benlemlih <[email protected]> Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> Co-authored-by: Manuel Schiller <[email protected]> Co-authored-by: Tanner Linsley <[email protected]> Co-authored-by: AlexisPin <[email protected]> Co-authored-by: timoconnellaus <[email protected]> Co-authored-by: Arnaud Kleinpeter <[email protected]> Co-authored-by: Joshua Knauber <[email protected]> Co-authored-by: Sean Cassiere <[email protected]> Co-authored-by: alakhpc <[email protected]> Co-authored-by: Mark Vu <[email protected]> Co-authored-by: Christopher Horobin <[email protected]> Co-authored-by: Muthu Kumar <[email protected]> Co-authored-by: Jeff Hertzler <[email protected]> Co-authored-by: Philippe Serhal <[email protected]> Co-authored-by: Andrei <[email protected]> Co-authored-by: Volodymyr <[email protected]> Co-authored-by: Vladimir Panov <[email protected]> Co-authored-by: pierluigigiancola <[email protected]> Co-authored-by: Tom Ballinger <[email protected]> Co-authored-by: Ben Durrant <[email protected]> Co-authored-by: Lukas Frey <[email protected]> Co-authored-by: John <[email protected]>

SeanCassiere and others added 14 commits November 16, 2024 14:41

test(start): e2e test to check for allowing a null return

4599915

chore: cleanup

5c32a5e

refactor(start): more readable

e5c1dca

Merge branch 'main' into fix/allow-server-fn-return-null

08b240f

fixup code

95ba6da

chore: overflow

bdc8f0f

Merge branch 'main' into fix/allow-server-fn-return-null

edc7939

Merge branch 'main' into fix/allow-server-fn-return-null

e43075f

chore: fixup merge issues

d23fa93

fix(start): intercepting Response returns on the server

7fad023

chore: update lockfile

c256525

Merge branch 'main' into fix/allow-server-fn-return-null

143b88f

Merge branch 'main' into fix/allow-server-fn-return-null

3ae0f16

Fix returning null from serverfns

fe8c907

alakhpc added 2 commits December 20, 2024 22:47

Merge branch 'fix/allow-server-fn-return-null' into fix-serverfn-null…

0b8a749

…-return

Fix test

a4c9ff0

This comment was marked as outdated.

Sign in to view

SeanCassiere reviewed Dec 21, 2024

View reviewed changes

e2e/start/basic/app/routes/-server-fns/allow-fn-return-null.tsx Outdated Show resolved Hide resolved

alakhpc and others added 2 commits December 21, 2024 20:10

update tests

0d2d648

Merge branch 'main' into fix-serverfn-null-return

9f7645d

SeanCassiere approved these changes Dec 22, 2024

View reviewed changes

packages/start/src/client/createServerFn.ts Show resolved Hide resolved

SeanCassiere changed the title ~~Fix returning null from serverfns~~ fix(start): returning null from server functions Dec 22, 2024

SeanCassiere merged commit 4a7d3ca into TanStack:main Dec 22, 2024
5 checks passed

SeanCassiere mentioned this pull request Dec 22, 2024

test(start): e2e test to check for allowing a null return #2778

Closed

tannerlinsley pushed a commit that referenced this pull request Jan 6, 2025

fix(start): returning null from server functions (#3048)

11f2b96

Co-authored-by: SeanCassiere <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(start): returning `null` from server functions #3048

fix(start): returning `null` from server functions #3048

alakhpc commented Dec 20, 2024

schiller-manuel commented Dec 20, 2024

This comment was marked as outdated.

nx-cloud bot commented Dec 21, 2024 •

edited

Loading

pkg-pr-new bot commented Dec 21, 2024 •

edited

Loading

SeanCassiere commented Dec 22, 2024

fix(start): returning null from server functions #3048

fix(start): returning null from server functions #3048

Conversation

alakhpc commented Dec 20, 2024

schiller-manuel commented Dec 20, 2024

This comment was marked as outdated.

nx-cloud bot commented Dec 21, 2024 • edited Loading

pkg-pr-new bot commented Dec 21, 2024 • edited Loading

SeanCassiere commented Dec 22, 2024

fix(start): returning `null` from server functions #3048

fix(start): returning `null` from server functions #3048

nx-cloud bot commented Dec 21, 2024 •

edited

Loading

pkg-pr-new bot commented Dec 21, 2024 •

edited

Loading