-
-
Notifications
You must be signed in to change notification settings - Fork 42
fix(core) derive auto mount #175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
I-am-abdulazeez
wants to merge
6
commits into
TanStack:main
Choose a base branch
from
I-am-abdulazeez:fix(core)-derive-auto-mount
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
fix(core) derive auto mount #175
I-am-abdulazeez
wants to merge
6
commits into
TanStack:main
from
I-am-abdulazeez:fix(core)-derive-auto-mount
+189
−127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi! I noticed that the workflow is waiting for approval. Is there anything I could do to move forward? |
View your CI Pipeline Execution ↗ for commit 0598842.
☁️ Nx Cloud last updated this comment at |
@tanstack/angular-store
@tanstack/react-store
@tanstack/store
@tanstack/solid-store
@tanstack/svelte-store
@tanstack/vue-store
commit: |
looks like you need to run docs:generate so that they aren't all deleted? |
@KevinVandy... They all deleted, can i still run docs:generate and push? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the mount method in the Derived class seems responsible for:
registerOnGraph()
).checkIfRecalculationNeededDeeply()
).unmounted
.The Solution
This approach automatically mounts when needed and cleans up when no one is listening, effectively removing the need for explicit
mount()
calls.