Skip to content

fix(core) derive auto mount #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

I-am-abdulazeez
Copy link

Currently, the mount method in the Derived class seems responsible for:

  • Registering dependencies in the graph (registerOnGraph()).
  • Checking if recomputation is needed (checkIfRecalculationNeededDeeply()).
  • Cleaning up dependencies when unmounted.

The Solution

This approach automatically mounts when needed and cleans up when no one is listening, effectively removing the need for explicit mount() calls.

@I-am-abdulazeez I-am-abdulazeez changed the title Fix(core) derive auto mount fix(core) derive auto mount Mar 11, 2025
@I-am-abdulazeez
Copy link
Author

Hi! I noticed that the workflow is waiting for approval. Is there anything I could do to move forward?

Copy link

nx-cloud bot commented Mar 11, 2025

View your CI Pipeline Execution ↗ for commit 0598842.

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ❌ Failed 1h 59m 50s View ↗
nx run-many --target=build --exclude=examples/** ✅ Succeeded 15s View ↗

☁️ Nx Cloud last updated this comment at 2025-03-11 19:18:32 UTC

Copy link

pkg-pr-new bot commented Mar 11, 2025

@tanstack/angular-store

npm i https://pkg.pr.new/@tanstack/angular-store@175

@tanstack/react-store

npm i https://pkg.pr.new/@tanstack/react-store@175

@tanstack/store

npm i https://pkg.pr.new/@tanstack/store@175

@tanstack/solid-store

npm i https://pkg.pr.new/@tanstack/solid-store@175

@tanstack/svelte-store

npm i https://pkg.pr.new/@tanstack/svelte-store@175

@tanstack/vue-store

npm i https://pkg.pr.new/@tanstack/vue-store@175

commit: 6ce0b96

@KevinVandy
Copy link
Member

looks like you need to run docs:generate so that they aren't all deleted?

@I-am-abdulazeez
Copy link
Author

@KevinVandy... They all deleted, can i still run docs:generate and push?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants