Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace esp_panic.h to avoid compiler warnings #7

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

kagehisa
Copy link

@kagehisa kagehisa commented Mar 4, 2020

Including esp_panic.h will generate a warning during compilation, since the file became deprecated.
By replacing it with esp_debug_helpers.h and esp_private/panic_reason.h, the generation of warnings can be avoided.

SveWoCo and others added 2 commits March 4, 2020 13:29
@AntumArk
Copy link

AntumArk commented Oct 1, 2020

So can this be merged?

@cmumford
Copy link

cmumford commented Feb 27, 2021

@kagehisa My fix was similar to yours:

#include <esp_idf_version.h>
#include <esp_log.h>

#if ESP_IDF_VERSION >= ESP_IDF_VERSION_VAL(4, 0, 0)
#include <esp_debug_helpers.h>
#else
#include <esp_panic.h>
#endif

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants