Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge: (#286) Schedule 도메인 리팩토링 #298

Merged
merged 6 commits into from
Jan 10, 2023

Conversation

softpeanut
Copy link
Member

작업 내용 설명

  • Schedule Aggregate 중심적으로 변경

주요 변경 사항

  • simtong-infrastructure build.gradle의 mapstruct default argument 제거

체크리스트

  • 어플리케이션 구동(혹은 테스트)시 오류는 없나요?
  • 생성된 코드에 Javadoc 주석을 추가 하였나요?
  • 생성된 코드에 대한 테스트 코드가 작성 되었나요?

관련 이슈

@softpeanut softpeanut added the refactor 코드 리팩토링 할 경우 label Jan 10, 2023
@softpeanut softpeanut requested a review from khcho0125 as a code owner January 10, 2023 00:38
@softpeanut softpeanut self-assigned this Jan 10, 2023
@codecov
Copy link

codecov bot commented Jan 10, 2023

Codecov Report

Merging #298 (4cab708) into develop (4cab708) will not change coverage.
The diff coverage is n/a.

❗ Current head 4cab708 differs from pull request most recent head 1d23a5f. Consider uploading reports for the commit 1d23a5f to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             develop     #298   +/-   ##
==========================================
  Coverage      37.70%   37.70%           
  Complexity       353      353           
==========================================
  Files            236      236           
  Lines           2854     2854           
  Branches         101      101           
==========================================
  Hits            1076     1076           
  Misses          1775     1775           
  Partials           3        3           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4cab708...1d23a5f. Read the comment docs.

Copy link
Member

@khcho0125 khcho0125 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

에잉 깔끔하네 💯

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@softpeanut softpeanut merged commit ffddcb0 into develop Jan 10, 2023
@softpeanut softpeanut deleted the refactor/286-domain-driven-code-schedule branch January 10, 2023 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor 코드 리팩토링 할 경우
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants