Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge: (#286) User 도메인 리팩토링 #307

Merged
merged 9 commits into from
Jan 13, 2023

Conversation

softpeanut
Copy link
Member

작업 내용 설명

  • Schedule Aggregate 중심적으로 변경

주요 변경 사항

  • 없음

체크리스트

  • 어플리케이션 구동(혹은 테스트)시 오류는 없나요?
  • 생성된 코드에 Javadoc 주석을 추가 하였나요?
  • 생성된 코드에 대한 테스트 코드가 작성 되었나요?

관련 이슈

@softpeanut softpeanut added the refactor 코드 리팩토링 할 경우 label Jan 13, 2023
@softpeanut softpeanut requested a review from khcho0125 as a code owner January 13, 2023 12:20
@softpeanut softpeanut self-assigned this Jan 13, 2023
@codecov
Copy link

codecov bot commented Jan 13, 2023

Codecov Report

Merging #307 (49d740a) into develop (020bbef) will increase coverage by 0.64%.
The diff coverage is 90.19%.

❗ Current head 49d740a differs from pull request most recent head 517c809. Consider uploading reports for the commit 517c809 to get more accurate results

Impacted file tree graph

@@              Coverage Diff              @@
##             develop     #307      +/-   ##
=============================================
+ Coverage      38.22%   38.87%   +0.64%     
- Complexity       355      370      +15     
=============================================
  Files            236      239       +3     
  Lines           2880     2899      +19     
  Branches          98       99       +1     
=============================================
+ Hits            1101     1127      +26     
+ Misses          1775     1766       -9     
- Partials           4        6       +2     
Impacted Files Coverage Δ
...omain/user/usecase/CheckEmailDuplicationUseCase.kt 100.00% <ø> (ø)
.../domain/user/usecase/CheckMatchedAccountUseCase.kt 100.00% <ø> (ø)
...in/user/usecase/CheckNicknameDuplicationUseCase.kt 100.00% <ø> (ø)
...omit/simtong/persistence/user/mapper/UserMapper.kt 0.00% <0.00%> (ø)
.../comit/simtong/domain/user/model/EmployeeNumber.kt 50.00% <50.00%> (ø)
...n/team/comit/simtong/domain/user/model/NickName.kt 50.00% <50.00%> (ø)
...n/team/comit/simtong/domain/user/model/Password.kt 50.00% <50.00%> (ø)
...otlin/team/comit/simtong/domain/user/model/User.kt 95.12% <93.75%> (-4.88%) ⬇️
.../simtong/domain/user/usecase/AdminSignInUseCase.kt 100.00% <100.00%> (ø)
.../simtong/domain/user/usecase/ChangeEmailUseCase.kt 100.00% <100.00%> (ø)
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 020bbef...517c809. Read the comment docs.

khcho0125
khcho0125 previously approved these changes Jan 13, 2023
Copy link
Member

@khcho0125 khcho0125 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@softpeanut softpeanut merged commit 0bd21fc into develop Jan 13, 2023
@softpeanut softpeanut deleted the refactor/286-domain-driven-code-user branch January 13, 2023 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor 코드 리팩토링 할 경우
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants