Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

๐Ÿ”€ :: [#100] Recommend Domain Setting #101

Merged
merged 13 commits into from
Jul 2, 2024

Conversation

Xixn2
Copy link
Member

@Xixn2 Xixn2 commented Jul 1, 2024

๐Ÿ“ƒ ์ž‘์—…๋‚ด์šฉ

Recommend ๋„๋ฉ”์ธ ์„ธํŒ…์„ ํ–ˆ์Šต๋‹ˆ๋‹ค.

@Xixn2 Xixn2 added โœจFeature ๊ธฐ๋Šฅ ์ถ”๊ฐ€ 0๏ธโƒฃPriority: Critical ์šฐ์„ ์ˆœ์œ„ - ๊ธด๊ธ‰ labels Jul 1, 2024
@Xixn2 Xixn2 requested review from shwaaaa and kimkyumbi July 1, 2024 08:12
@Xixn2 Xixn2 self-assigned this Jul 1, 2024
@Xixn2 Xixn2 linked an issue Jul 1, 2024 that may be closed by this pull request
Comment on lines +1 to +5
import Foundation

public protocol RecommendRepository {
func fetchRecommend(params: String) async throws -> RecommendBookEntity
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

String์ด ์•„๋‹ˆ๋ผ type enum ๋งŒ๋“ค์–ด์„œ ๋ณ€๊ฒฝํ•˜์…”์•ผ ํ•  ๊ฒƒ ๊ฐ™์•„์š”

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Enum ์ƒ์„ฑ Commit
898f912

Enum ์ ์šฉ Commit
dca5d1e

Enum์œผ๋กœ ๋„˜๊ธฐ๋„๋ก ๋ณ€๊ฒฝํ–ˆ์Šต๋‹ˆ๋‹ค!

Comment on lines 1 to 6
//
// RecommendEnum.swift
// Service
//
// Created by ์„œ์ง€์™„ on 7/2/24.
//
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์ง€์›Œ์ฃผ์„ธ์š”

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

01b60e3
์ œ๊ฑฐํ–ˆ์Šต๋‹ˆ๋‹ค!

@Team-MindWay Team-MindWay deleted a comment from shwaaaa Jul 2, 2024
@Xixn2 Xixn2 merged commit 87a947a into master Jul 2, 2024
2 checks passed
@kimkyumbi kimkyumbi deleted the 100-recommend-domain-setting branch July 28, 2024 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0๏ธโƒฃPriority: Critical ์šฐ์„ ์ˆœ์œ„ - ๊ธด๊ธ‰ โœจFeature ๊ธฐ๋Šฅ ์ถ”๊ฐ€
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Recommend ๋„๋ฉ”์ธ ์„ธํŒ…
3 participants