♻️ :: 피드 상태 관리 리팩토링

Team-SIGNAL · Nov 16, 2023 · abe94ba · abe94ba
1 parent a9fe42d
commit abe94ba
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 20 deletions.
diff --git a/presentation/src/main/java/com/signal/signal_android/feature/main/feed/Feed.kt b/presentation/src/main/java/com/signal/signal_android/feature/main/feed/Feed.kt
@@ -69,14 +69,12 @@ internal fun Feed(
     var showDialog by remember { mutableStateOf(false) }
 
     val alpha by animateFloatAsState(
-        targetValue = if (state.isPostsEmpty) 1f else 0f,
+        targetValue = if (state.posts.isEmpty()) 1f else 0f,
         label = "",
     )
 
     LaunchedEffect(Unit) {
-        if (state.isPostsEmpty) {
-            feedViewModel.fetchPosts()
-        }
+        feedViewModel.fetchPosts()
     }
 
     if (showDialog) {
@@ -120,7 +118,7 @@ internal fun Feed(
                 Posts(
                     moveToFeedDetails = moveToFeedDetails,
                     moveToReport = moveToReport,
-                    posts = state.posts,
+                    posts = { state.posts },
                     showDropDown = {
                         feedViewModel.setFeedId(it)
                         expanded = it
@@ -152,7 +150,7 @@ internal fun Feed(
                     Body(
                         modifier = Modifier.signalClickable(
                             onClick = moveToCreatePost,
-                            enabled = state.isPostsEmpty
+                            enabled = state.posts.isEmpty()
                         ),
                         text = stringResource(id = R.string.feed_posts_add),
                         color = SignalColor.Primary100,
@@ -244,13 +242,13 @@ private fun Posts(
     moveToFeedDetails: (feedId: Long) -> Unit,
     moveToReport: () -> Unit,
     showDropDown: (feedId: Long) -> Unit,
-    posts: List<PostsEntity.PostEntity>,
+    posts: () -> List<PostsEntity.PostEntity>,
     onDismissRequest: () -> Unit,
     expanded: Long,
     onDelete: () -> Unit,
 ) {
     LazyColumn(modifier = Modifier.fillMaxSize()) {
-        items(posts) {
+        items(posts()) {
             Post(
                 moveToFeedDetails = { moveToFeedDetails(it.id) },
                 imageUrl = it.image,

diff --git a/presentation/src/main/java/com/signal/signal_android/feature/main/feed/FeedState.kt b/presentation/src/main/java/com/signal/signal_android/feature/main/feed/FeedState.kt
@@ -12,7 +12,6 @@ data class FeedState(
     val tag: Tag,
     val page: Long,
     val size: Long,
-    val isPostsEmpty: Boolean,
     val title: String,
     val content: String,
     val postDetailsEntity: PostDetailsEntity,
@@ -27,7 +26,6 @@ data class FeedState(
             tag = Tag.GENERAL,
             page = 0,
             size = 8,
-            isPostsEmpty = true,
             title = "",
             content = "",
             postDetailsEntity = PostDetailsEntity(

diff --git a/presentation/src/main/java/com/signal/signal_android/feature/main/feed/FeedViewModel.kt b/presentation/src/main/java/com/signal/signal_android/feature/main/feed/FeedViewModel.kt
@@ -27,15 +27,9 @@ internal class FeedViewModel(
                         size = size,
                     )
                 }.onSuccess {
+                    _posts.clear()
                     _posts.addAll(it.postEntities)
-                    setState(
-                        copy(
-                            posts = _posts.toMutableStateList(),
-                            isPostsEmpty = _posts.isEmpty(),
-                        )
-                    )
-                }.onFailure {
-                    setState(copy(isPostsEmpty = _posts.isEmpty()))
+                    setState(copy(posts = _posts.toMutableStateList()))
                 }
             }
         }
@@ -50,6 +44,7 @@ internal class FeedViewModel(
                     image = imageUrl,
                 ).onSuccess {
                     postSideEffect(FeedSideEffect.PostSuccess)
+                    fetchPosts()
                 }
             }
         }
@@ -108,11 +103,17 @@ internal class FeedViewModel(
 
     internal fun deletePost() {
         with(state.value) {
+            val remove = {
+                _posts.remove(_posts.find { it.id == feedId })
+                setState(copy(posts = _posts.toMutableStateList()))
+            }
             viewModelScope.launch(Dispatchers.IO) {
                 feedRepository.deletePost(feedId = feedId).onSuccess {
-
+                    remove()
                 }.onFailure {
-
+                    if (it is KotlinNullPointerException) {
+                        remove()
+                    }
                 }
             }
         }