This repository has been archived by the owner on Mar 8, 2024. It is now read-only.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Tmdhoon2
suggested changes
Nov 20, 2023
presentation/src/main/java/com/signal/signal_android/feature/main/diary/CreateDiary.kt
Outdated
Show resolved
Hide resolved
| @@ -1,5 +1,7 @@ | |||
| package com.signal.signal_android.feature.main.diary | |||
|
|
|||
| import android.util.Log | |||
presentation/src/main/java/com/signal/signal_android/feature/main/diary/DiaryViewModel.kt
Show resolved
Hide resolved
| setState(copy(diaries = _diaries.toMutableStateList())) | ||
| } | ||
| viewModelScope.launch(Dispatchers.IO) { | ||
| diaryRepository.deleteDiary(diaryId = diaryId).onSuccess { |
There was a problem hiding this comment.
여기도 fail에서 NPE인 경우랑 동일하게 처리해줘야 할 것 같아요
There was a problem hiding this comment.
이거 왠지 모르겠는데 요청이 success에도 가고 failure에도 가서 하나에만 처리해줬어요
| onLeadingClicked = moveToBack, | ||
| trailingIcon = painterResource(id = R.drawable.ic_delete), | ||
| onTrailingClicked = {/*TODO delete*/} | ||
| ) | ||
| onTrailingClicked = { diaryViewModel.deleteDiary() }) |
There was a problem hiding this comment.
trailingClicked인데 trailingComma가 없네요 🤣🤣
Tmdhoon2
approved these changes
Nov 20, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
개요
작업사항
추가 로 할 말