Skip to content
This repository has been archived by the owner on Mar 8, 2024. It is now read-only.

πŸ”€ :: (#78) λŒ“κΈ€ μž‘μ„± κ΅¬ν˜„ #87

Merged
merged 7 commits into from
Nov 14, 2023
Merged

πŸ”€ :: (#78) λŒ“κΈ€ μž‘μ„± κ΅¬ν˜„ #87

merged 7 commits into from
Nov 14, 2023

Conversation

Tmdhoon2
Copy link
Collaborator

κ°œμš”

λŒ“κΈ€ μž‘μ„± μ„œλ²„ 연동 μ½”λ“œλ₯Ό μž‘μ„±ν–ˆμŠ΅λ‹ˆλ‹€.

μž‘μ—…μ‚¬ν•­

μΆ”κ°€ 둜 ν•  말

@Tmdhoon2 Tmdhoon2 added the κΈ°λŠ₯ κ΅¬ν˜„ μƒˆλ‘œμš΄ κΈ°λŠ₯ κ΅¬ν˜„ label Nov 14, 2023
@Tmdhoon2 Tmdhoon2 requested a review from chlgkdms November 14, 2023 10:50
@Tmdhoon2 Tmdhoon2 self-assigned this Nov 14, 2023
@Tmdhoon2 Tmdhoon2 linked an issue Nov 14, 2023 that may be closed by this pull request
λŒ“κΈ€ μž‘μ„± κ΅¬ν˜„ #78
Closed
chlgkdms
chlgkdms suggested changes Nov 14, 2023
View reviewed changes
data/src/main/kotlin/com/signal/data/model/feed/request/CreatePostRequest.kt
import com.google.gson.annotations.SerializedName

data class CreatePostRequest(
@SerializedName("content") val content: String,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이 파일 ν˜Ήμ‹œ λŒ“κΈ€ μž‘μ„± request이면 클래슀 넀이밍 λ‹€μ‹œν•˜λŠ”κ²Œ 쒋지 μ•Šμ„κΉŒμš”?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ν”Όλ“œ μž‘μ„±μ΄λž‘ ν—·κ°ˆλ €μš”

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

μ•„ κ·ΈλŸ¬λ„€μš”

presentation/src/main/java/com/signal/signal_android/feature/main/feed/FeedViewModel.kt
@@ -81,13 +81,30 @@ internal class FeedViewModel(
with(state.value) {
viewModelScope.launch(Dispatchers.IO) {
feedRepository.fetchPostComments(feedId).onSuccess {
_comments.clear()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이거 μ™œ clear λ©”μ†Œλ“œ μ“°μ…¨λ‚˜μš”?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

μ•„ 아직은 κ΅¬ν˜„ 방법이 λ”±νžˆ λ– μ˜€λ₯΄μ§€ μ•Šμ•„μ„œ λŒ“κΈ€ μž‘μ„± μ„±κ³΅ν• λ•Œλ§ˆλ‹€ λŒ“κΈ€ 전체 리슀트λ₯Ό λ‹€μ‹œ μ‘°νšŒν•˜λ„λ‘ κ΅¬ν˜„ν•΄λ†¨λŠ”λ° λŒ“κΈ€ 리슀트λ₯Ό μ΄ˆκΈ°ν™” ν•˜μ§€ μ•ŠμœΌλ©΄ 뢈러였기 μ „ 데이터가 κ·ΈλŒ€λ‘œ λ‚¨μ•„μžˆμ–΄μš”

κ·Έλž˜μ„œ ν•΄μ€Œ

@Tmdhoon2 Tmdhoon2 requested a review from chlgkdms November 14, 2023 12:40
@Tmdhoon2 Tmdhoon2 merged commit cfb930c into develop Nov 14, 2023
@Tmdhoon2 Tmdhoon2 deleted the feature/78-λŒ“κΈ€-μž‘μ„±-κ΅¬ν˜„ branch November 14, 2023 13:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chlgkdms chlgkdms chlgkdms approved these changes

Assignees

@Tmdhoon2 Tmdhoon2

Labels
κΈ°λŠ₯ κ΅¬ν˜„ μƒˆλ‘œμš΄ κΈ°λŠ₯ κ΅¬ν˜„
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

λŒ“κΈ€ μž‘μ„± κ΅¬ν˜„
2 participants
@Tmdhoon2 @chlgkdms