[feat] 휴지통페이지 디자인 QA + 팀용량 api #457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
February 1, 2025 11:24
rtttr1
approved these changes
Feb 6, 2025
| }, | ||
| }); | ||
|
|
||
| const convertUnit = 1024 * 1024; |
There was a problem hiding this comment.
상수니까 리랜더링에 영향 안받게 함수 밖으로 빼버리거나 파일 분리하는게 좋겠네요!
namdaeun
reviewed
Feb 6, 2025
Comment on lines
112
to
113
| { onSuccess: () => usageRefetch() } | ||
| ); |
There was a problem hiding this comment.
onSuccess시에도 성공했다는 토스트 띄워주는 건 어떵가요 ?
There was a problem hiding this comment.
이게 deletemutation이라 성공했을 때 토스트가 뜨도록 설정해놨습니다!
Comment on lines
17
to
21
| const capacity = (data?.data?.capacity || 0) / convertUnit / convertUnit; | ||
| const availableUsage = capacity - (data?.data?.usage || 0) / convertUnit; | ||
|
|
||
| const modifiedCapacity = Math.floor(capacity * 1000) / 1000; | ||
| const modifiedAvailableUsage = Math.ceil(availableUsage * 1000) / 1000; |
There was a problem hiding this comment.
요게 GB로 변환하는 로직이라면 util로 분리하고 호출해서 값을 리턴하는 방식이 가독성이 더 높아질 것 같습니다!
그리고 api 관련 훅이니까 hook/api에 위치하는 게 좋을 것 가타요!
added 2 commits
February 6, 2025 16:59
…to style/deleted/#446-QA
wuzoo
approved these changes
Feb 8, 2025
apps/client/src/page/drive/index.tsx
Outdated
Comment on lines
81
to
84
| useEffect(() => { | ||
| usageRefetch(); | ||
| }, [filteredResult, usageRefetch]); | ||
|
|
There was a problem hiding this comment.
filteredResult 를 쿼리 키에 넣어서 자동으로 리패치하도록 하는 것이 더 좋을 것 같아요 !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
해당 이슈 번호
closed #446
체크리스트
💎 PR Point
그리구 팀용량 api를 받아와서 GB로 단위 변환하여 출력했습니다.
단위 변환과 사용가능 용량 계산 하는 유틸함수를 만들었습니다.
📌스크린샷 (선택)