Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] 로그인 페이지 디자인 QA #483

Merged
merged 2 commits into from
Feb 26, 2025
Merged

Conversation

wuzoo
Copy link
Member

@wuzoo wuzoo commented Feb 23, 2025

해당 이슈 번호

closed #480


체크리스트

  • 🔀 PR 제목의 형식을 잘 작성했나요? e.g. [feat] PR을 등록한다.
  • 💯 테스트는 잘 통과했나요?
  • 🏗️ 빌드는 성공했나요?
  • 🧹 불필요한 코드는 제거했나요?
  • ✅ 컨벤션을 지켰나요?
  • 💭 이슈는 등록했나요?
  • 🏷️ 라벨은 등록했나요?
  • 🙇‍♂️ 리뷰어를 지정했나요?

💎 PR Point

디자인 QA 진행하였습니다.

로그인 페이지 들어갔을 때 바로 email 인풋이 포커스될 수 있도록 하였습니다. 이 부분은 디자이너와 합의 후 결정하였습니다.

다른 건 사소한 스타일들 수정입니다 !

Copy link

🚀 Storybook 확인하기 🚀

Copy link
Contributor

@Bowoon1216 Bowoon1216 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 수고하셨습니다!

Copy link
Member

@namdaeun namdaeun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@wuzoo wuzoo self-assigned this Feb 25, 2025
Copy link
Contributor

@rtttr1 rtttr1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~~~!!!

@wuzoo wuzoo merged commit ae6b558 into develop Feb 26, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

로그인 페이지 QA
4 participants