[Fix] 초대 페이지 및 대시보드 페이지 QA #499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rtttr1
approved these changes
Mar 4, 2025
wuzoo
reviewed
Mar 4, 2025
| } | ||
| }, [createToast, data, failureCount, invitationId, invitationInfo?.teamId, isLogined, navigate]); | ||
| // eslint-disable-next-line react-hooks/exhaustive-deps |
There was a problem hiding this comment.
useEffect안에서 handleApiError 함수를 호출했는데 이 함수도 의존성배열로 취급해버려 함수는 랜더링될때마다 새로 생성되고 useEffect도 매번 생성되는 경고가 떠서 저걸로 막았습니다.
근데 이제 생각해보니 저 함수는 useEffect안에서만 사용이 되므로 안에서 생성하면 의존성배열에 추가하지 않아도 되더라구요!? 그래서 안으로 모셨습니다.~
Comment on lines
+74
to
+82
| onSuccess: (res) => { | ||
| if (res.success) { | ||
| createToast(res.message, 'success'); | ||
|
|
||
| localStorage.setItem(STORAGE_KEY.TEAM_ID, `${teamId}`); | ||
| localStorage.setItem(STORAGE_KEY.TEAM_NAME, `${invitationInfo?.teamName}`); | ||
| } else { | ||
| createToast(res.message, 'error'); | ||
| } |
There was a problem hiding this comment.
왜 이렇게 하신거죠 ? onSuccess가 이미 쿼리로 데이터를 가져오는데 성공했을 때 콜백이 실행하므로 재검증하는 로직은 불필요할 것 같아요
There was a problem hiding this comment.
초대 수락에 실패해도 onSuccess로 들어와서 res.success 확인을 하지 않으면 '이미 존재하는 회원입니다'와 같은 에러 메시지도 success toast로 뜹니다.
제 생각엔 api 결과가 모두 { success: boolean, message: string } 객체로 반환되어 실패하든 성공하든 onSuccess함수로 들어오게 되는 것 같습니다. 그래서 onSuccess 안에서 다시 구분해줬습니다.
namdaeun
approved these changes
Mar 5, 2025
Comment on lines
+74
to
+82
| onSuccess: (res) => { | ||
| if (res.success) { | ||
| createToast(res.message, 'success'); | ||
|
|
||
| localStorage.setItem(STORAGE_KEY.TEAM_ID, `${teamId}`); | ||
| localStorage.setItem(STORAGE_KEY.TEAM_NAME, `${invitationInfo?.teamName}`); | ||
| } else { | ||
| createToast(res.message, 'error'); | ||
| } |
Comment on lines
+105
to
+110
| onSuccess: (res) => { | ||
| if (res.success) { | ||
| createToast(res.message, 'success'); | ||
| } else { | ||
| createToast(res.message, 'error'); | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
해당 이슈 번호
closed #498
체크리스트
💎 PR Point
📌스크린샷 (선택)