[Refactor] qa 해결 #500
Merged
[Refactor] qa 해결 #500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wuzoo
approved these changes
Mar 4, 2025
| const { mutate: deleteTeamMutate } = useMutation({ | ||
| mutationFn: ({ teamId }: { teamId: number }) => deleteTeam(teamId), | ||
| onSuccess: async () => { | ||
| await queryClient.invalidateQueries({ |
Comment on lines
+37
to
+40
| onClick={(e) => { | ||
| e.stopPropagation(); | ||
| setSelectedDate(date); | ||
| }} |
Bowoon1216
approved these changes
Mar 5, 2025
| }, | ||
| onError: (error) => { | ||
| createToast(TIMEBLOCK.ERROR.DELETE, 'error'); | ||
| console.log(error); |
| onError: () => createToast(NOTE.ERROR.DELETE, 'error'), | ||
| onError: (error) => { | ||
| createToast(NOTE.ERROR.DELETE, 'error'); | ||
| console.log(error); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
해당 이슈 번호
closed #495
체크리스트
📌 내가 알게 된 부분
💎 PR Point
204 delete 긴급 처방
현재 204로 delete 성공이 되는 api에서 오류가 발생합니다..!
원인으로는 서버에서 삭제로직 실행 후 빈 응답값을 전달하는데 그 빈 응답값에 oas가 접근을 하려고 해서 나는 것으로 추정하고 있습니다.
일단 급하게 불을 끄고자 현재 204로 응답값이 오는 delete api들을 보이는대로 oas를 사용하지 않고 axios를 사용하는 코드로 변경해주었습니다. 혹시 빠진 api가 있으면 알려주시면 처리 마저 해두겠습니다!
datepicker 클릭 오류 해결
문제상황은 다음과 같습니다.
따라서
stopPropagation으로 버블링을 막아서 해결했습니다!그 외에는 자잘한 qa들 처리했습니다!
📌스크린샷 (선택)