🔗 :: (#602) exception 던지는 조건문 메서드로 분리, from of 구분

🔗 :: (#602) exception 던지는 조건문 메서드로 분리, from of 구분

jobis-application/src/main/java/team/retum/jobis/common/spi/SecurityPort.java

@@ -3,7 +3,6 @@
 import team.retum.jobis.domain.auth.model.Authority;
 import team.retum.jobis.domain.company.model.Company;
 import team.retum.jobis.domain.student.model.Student;
-import team.retum.jobis.domain.teacher.model.Teacher;
 import team.retum.jobis.domain.user.model.User;
 
 public interface SecurityPort {

jobis-application/src/main/java/team/retum/jobis/domain/acceptance/dto/response/TeacherQueryFieldTraineesAndContractWorkersResponse.java

@@ -3,6 +3,9 @@
 import lombok.AllArgsConstructor;
 import lombok.Builder;
 import lombok.Getter;
+import team.retum.jobis.domain.acceptance.spi.vo.AcceptanceVO;
+import team.retum.jobis.domain.application.spi.vo.FieldTraineesVO;
+import team.retum.jobis.domain.student.model.SchoolNumber;
 
 import java.time.LocalDate;
 import java.util.List;
@@ -22,6 +25,28 @@ public static class TeacherQueryFieldTraineesResponse {
         private String studentName;
         private LocalDate startDate;
         private LocalDate endDate;
+
+        public static List<TeacherQueryFieldTraineesResponse> from(List<FieldTraineesVO> fieldTrainees) {
+            return fieldTrainees.stream()
+                    .map(
+                            fieldTrainee -> TeacherQueryFieldTraineesResponse
+                                    .builder()
+                                    .applicationId(fieldTrainee.getApplicationId())
+                                    .studentGcn(
+                                            SchoolNumber.processSchoolNumber(
+                                                    SchoolNumber.builder()
+                                                            .grade(fieldTrainee.getGrade())
+                                                            .classRoom(fieldTrainee.getClassRoom())
+                                                            .number(fieldTrainee.getNumber())
+                                                            .build()
+                                            )
+                                    )
+                                    .studentName(fieldTrainee.getStudentName())
+                                    .startDate(fieldTrainee.getStartDate())
+                                    .endDate(fieldTrainee.getEndDate())
+                                    .build()
+                    ).toList();
+        }
     }
 
     @Getter
@@ -31,5 +56,26 @@ public static class TeacherQueryContractWorkersResponse {
         private String studentGcn;
         private String studentName;
         private LocalDate contractDate;
+
+        public static List<TeacherQueryContractWorkersResponse> from(List<AcceptanceVO> acceptances) {
+            return acceptances.stream()
+                    .map(
+                            acceptance -> TeacherQueryContractWorkersResponse
+                                    .builder()
+                                    .acceptanceId(acceptance.getAcceptanceId())
+                                    .studentGcn(
+                                            SchoolNumber.processSchoolNumber(
+                                                    SchoolNumber.builder()
+                                                            .grade(acceptance.getGrade())
+                                                            .classRoom(acceptance.getClassRoom())
+                                                            .number(acceptance.getNumber())
+                                                            .build()
+                                            )
+                                    )
+                                    .studentName(acceptance.getStudentName())
+                                    .contractDate(acceptance.getContractDate())
+                                    .build()
+                    ).toList();
+        }
     }
 }

jobis-application/src/main/java/team/retum/jobis/domain/acceptance/usecase/CancelFieldTraineesUseCase.java

@@ -24,8 +24,11 @@ public void execute(List<Long> applicationIds) {
             throw ApplicationNotFoundException.EXCEPTION;
         }
 
-        applications.forEach(application ->
-                application.checkApplicationStatus(application.getApplicationStatus(), ApplicationStatus.FIELD_TRAIN)
+        applications.forEach(
+                application -> Application.checkApplicationStatus(
+                        application.getApplicationStatus(),
+                        ApplicationStatus.FIELD_TRAIN
+                )
         );
 
         commandApplicationPort.changeApplicationStatus(

jobis-application/src/main/java/team/retum/jobis/domain/acceptance/usecase/RegisterEmploymentContractUseCase.java

@@ -5,7 +5,7 @@
 import team.retum.jobis.domain.acceptance.model.Acceptance;
 import team.retum.jobis.domain.acceptance.spi.CommandAcceptancePort;
 import team.retum.jobis.domain.application.exception.ApplicationNotFoundException;
-import team.retum.jobis.domain.application.exception.ApplicationStatusCannotChangeException;
+import team.retum.jobis.domain.application.model.Application;
 import team.retum.jobis.domain.application.model.ApplicationStatus;
 import team.retum.jobis.domain.application.spi.CommandApplicationPort;
 import team.retum.jobis.domain.application.spi.QueryApplicationPort;
@@ -32,9 +32,10 @@ public void execute(List<String> codeKeywords, List<Long> applicationIds) {
         List<Acceptance> acceptances = applications.stream()
                 .map(
                         application -> {
-                            if (application.getStatus() != ApplicationStatus.FIELD_TRAIN) {
-                                throw ApplicationStatusCannotChangeException.EXCEPTION;
-                            }
+                            Application.checkApplicationStatus(
+                                    application.getStatus(),
+                                    ApplicationStatus.FIELD_TRAIN
+                            );
 
                             return Acceptance.builder()
                                     .companyId(application.getCompanyId())

jobis-application/src/main/java/team/retum/jobis/domain/acceptance/usecase/TeacherQueryFieldTraineesAndContractWorkersUseCase.java

@@ -9,7 +9,6 @@
 import team.retum.jobis.domain.acceptance.spi.vo.AcceptanceVO;
 import team.retum.jobis.domain.application.spi.QueryApplicationPort;
 import team.retum.jobis.domain.application.spi.vo.FieldTraineesVO;
-import team.retum.jobis.domain.student.model.SchoolNumber;
 
 import java.time.Year;
 import java.util.List;
@@ -26,55 +25,8 @@ public TeacherQueryFieldTraineesAndContractWorkersResponse execute(Long companyI
         List<AcceptanceVO> acceptances = queryAcceptancePort.queryAcceptancesByCompanyIdAndYear(companyId, Year.now().getValue());
 
         return new TeacherQueryFieldTraineesAndContractWorkersResponse(
-                buildFieldTrainees(fieldTrainees),
-                buildContractWorkers(acceptances)
+                TeacherQueryFieldTraineesResponse.from(fieldTrainees),
+                TeacherQueryContractWorkersResponse.from(acceptances)
         );
     }
-
-    private List<TeacherQueryFieldTraineesResponse> buildFieldTrainees(
-            List<FieldTraineesVO> fieldTrainees
-    ) {
-        return fieldTrainees.stream()
-                .map(
-                        fieldTrainee -> TeacherQueryFieldTraineesResponse
-                                .builder()
-                                .applicationId(fieldTrainee.getApplicationId())
-                                .studentGcn(
-                                        SchoolNumber.processSchoolNumber(
-                                                SchoolNumber.builder()
-                                                        .grade(fieldTrainee.getGrade())
-                                                        .classRoom(fieldTrainee.getClassRoom())
-                                                        .number(fieldTrainee.getNumber())
-                                                        .build()
-                                        )
-                                )
-                                .studentName(fieldTrainee.getStudentName())
-                                .startDate(fieldTrainee.getStartDate())
-                                .endDate(fieldTrainee.getEndDate())
-                                .build()
-                ).toList();
-    }
-
-    private List<TeacherQueryContractWorkersResponse> buildContractWorkers(
-            List<AcceptanceVO> acceptances
-    ) {
-        return acceptances.stream()
-                .map(
-                        acceptance -> TeacherQueryContractWorkersResponse
-                                .builder()
-                                .acceptanceId(acceptance.getAcceptanceId())
-                                .studentGcn(
-                                        SchoolNumber.processSchoolNumber(
-                                                SchoolNumber.builder()
-                                                        .grade(acceptance.getGrade())
-                                                        .classRoom(acceptance.getClassRoom())
-                                                        .number(acceptance.getNumber())
-                                                        .build()
-                                        )
-                                )
-                                .studentName(acceptance.getStudentName())
-                                .contractDate(acceptance.getContractDate())
-                                .build()
-                ).toList();
-    }
 }

jobis-application/src/main/java/team/retum/jobis/domain/application/dto/response/QueryMyApplicationsResponse.java

@@ -14,7 +14,7 @@ public class QueryMyApplicationsResponse {
 
     private final List<QueryMyApplicationResponse> applications;
 
-    public static QueryMyApplicationsResponse of(List<ApplicationVO> applicationVOs) {
+    public static QueryMyApplicationsResponse from(List<ApplicationVO> applicationVOs) {
         return new QueryMyApplicationsResponse(
                 applicationVOs.stream()
                         .map(application -> QueryMyApplicationResponse.builder()

jobis-application/src/main/java/team/retum/jobis/domain/application/dto/response/QueryPassedApplicationStudentsResponse.java

@@ -16,7 +16,7 @@ public class QueryPassedApplicationStudentsResponse {
 
     private final List<QueryPassedApplicationStudentResponse> students;
 
-    public static QueryPassedApplicationStudentResponse of(PassedApplicationStudentsVO vo) {
+    public static QueryPassedApplicationStudentResponse from(PassedApplicationStudentsVO vo) {
         return QueryPassedApplicationStudentResponse.builder()
                 .applicationId(vo.getApplicationId())
                 .studentName(vo.getStudentName())

jobis-application/src/main/java/team/retum/jobis/domain/application/event/ApplicationsStatusChangedEvent.java

@@ -1,7 +1,6 @@
 package team.retum.jobis.domain.application.event;
 
 import lombok.AllArgsConstructor;
-import lombok.Builder;
 import lombok.Getter;
 import team.retum.jobis.domain.application.model.Application;
 import team.retum.jobis.domain.application.model.ApplicationStatus;

jobis-application/src/main/java/team/retum/jobis/domain/application/model/Application.java

@@ -68,7 +68,7 @@ public void checkReviewAuthority() {
         }
     }
 
-    public void checkApplicationStatus(ApplicationStatus requestedStatus, ApplicationStatus... baseStatuses) {
+    public static void checkApplicationStatus(ApplicationStatus requestedStatus, ApplicationStatus... baseStatuses) {
         if (!List.of(baseStatuses).contains(requestedStatus)) {
             throw ApplicationStatusCannotChangeException.EXCEPTION;
         }

jobis-application/src/main/java/team/retum/jobis/domain/application/model/ApplicationAttachment.java

@@ -2,6 +2,9 @@
 
 import lombok.AllArgsConstructor;
 import lombok.Getter;
+import team.retum.jobis.domain.application.dto.request.AttachmentRequest;
+
+import java.util.List;
 
 @Getter
 @AllArgsConstructor
@@ -10,4 +13,10 @@ public class ApplicationAttachment {
     private final String attachmentUrl;
 
     private final AttachmentType type;
+
+    public static List<ApplicationAttachment> from(List<AttachmentRequest> requests) {
+        return requests.stream()
+                .map(request -> new ApplicationAttachment(request.url(), request.type()))
+                .toList();
+    }
 }

jobis-application/src/main/java/team/retum/jobis/domain/application/spi/QueryApplicationPort.java

@@ -1,7 +1,7 @@
 package team.retum.jobis.domain.application.spi;
 
-import team.retum.jobis.domain.application.model.Application;
 import team.retum.jobis.domain.application.dto.ApplicationFilter;
+import team.retum.jobis.domain.application.model.Application;
 import team.retum.jobis.domain.application.model.ApplicationStatus;
 import team.retum.jobis.domain.application.spi.vo.ApplicationDetailVO;
 import team.retum.jobis.domain.application.spi.vo.ApplicationVO;

jobis-application/src/main/java/team/retum/jobis/domain/application/usecase/ChangeFieldTrainDateUseCase.java

@@ -20,10 +20,12 @@ public class ChangeFieldTrainDateUseCase {
     public void execute(ChangeFieldTrainDateRequest request) {
         List<Application> applications = queryApplicationPort.queryApplicationsByIds(request.applicationIds());
 
-        applications
-                .forEach(application ->
-                        application.checkApplicationStatus(application.getApplicationStatus(), ApplicationStatus.FIELD_TRAIN)
-                );
+        applications.forEach(
+                application -> Application.checkApplicationStatus(
+                        application.getApplicationStatus(),
+                        ApplicationStatus.FIELD_TRAIN
+                )
+        );
 
         commandApplicationPort.updateFieldTrainDate(
                 request.startDate(),

jobis-application/src/main/java/team/retum/jobis/domain/application/usecase/CompanyQueryApplicationsUseCase.java

@@ -3,8 +3,8 @@
 import lombok.RequiredArgsConstructor;
 import team.retum.jobis.common.annotation.ReadOnlyUseCase;
 import team.retum.jobis.common.spi.SecurityPort;
-import team.retum.jobis.domain.application.dto.response.CompanyQueryApplicationsResponse;
 import team.retum.jobis.domain.application.dto.ApplicationFilter;
+import team.retum.jobis.domain.application.dto.response.CompanyQueryApplicationsResponse;
 import team.retum.jobis.domain.application.model.ApplicationStatus;
 import team.retum.jobis.domain.application.spi.QueryApplicationPort;
 import team.retum.jobis.domain.application.spi.vo.ApplicationVO;

jobis-application/src/main/java/team/retum/jobis/domain/application/usecase/CreateApplicationUseCase.java

@@ -32,22 +32,10 @@ public void execute(Long recruitmentId, List<AttachmentRequest> attachmentReques
                 .orElseThrow(() -> RecruitmentNotFoundException.EXCEPTION);
 
         recruitment.checkIsApplicable(student.getEntranceYear());
+        checkApplicationDuplicated(student.getId());
+        checkApplicationAlreadyApply(student.getId(), recruitment.getId());
 
-        if (queryApplicationPort.existsApplicationByStudentIdAndApplicationStatusIn(
-                student.getId(), ApplicationStatus.DUPLICATE_CHECK
-        )) {
-            throw ApplicationAlreadyExistsException.EXCEPTION;
-        }
-
-        if (queryApplicationPort.existsApplicationByStudentIdAndRecruitmentId(student.getId(), recruitment.getId())) {
-            throw ApplicationAlreadyExistsException.EXCEPTION;
-        }
-
-        List<ApplicationAttachment> attachments = attachmentRequests
-                .stream()
-                .map(attachment -> new ApplicationAttachment(attachment.url(), attachment.type()))
-                .toList();
-
+        List<ApplicationAttachment> attachments = ApplicationAttachment.from(attachmentRequests);
         commandApplicationPort.saveApplication(
                 Application.builder()
                         .studentId(student.getId())
@@ -57,4 +45,19 @@ public void execute(Long recruitmentId, List<AttachmentRequest> attachmentReques
                         .build()
         );
     }
+
+    private void checkApplicationDuplicated(Long studentId) {
+        if (queryApplicationPort.existsApplicationByStudentIdAndApplicationStatusIn(
+                studentId,
+                ApplicationStatus.DUPLICATE_CHECK
+        )) {
+            throw ApplicationAlreadyExistsException.EXCEPTION;
+        }
+    }
+
+    private void checkApplicationAlreadyApply(Long studentId, Long recruitmentId) {
+        if (queryApplicationPort.existsApplicationByStudentIdAndRecruitmentId(studentId, recruitmentId)) {
+            throw ApplicationAlreadyExistsException.EXCEPTION;
+        }
+    }
 }

jobis-application/src/main/java/team/retum/jobis/domain/application/usecase/DeleteApplicationUseCase.java

@@ -19,7 +19,6 @@ public class DeleteApplicationUseCase {
 
     public void execute(Long applicationId) {
         Student student = securityPort.getCurrentStudent();
-
         Application application = queryApplicationPort.queryApplicationById(applicationId)
                 .orElseThrow(() -> ApplicationNotFoundException.EXCEPTION);
 

jobis-application/src/main/java/team/retum/jobis/domain/application/usecase/QueryMyApplicationsUseCase.java

@@ -3,8 +3,8 @@
 import lombok.RequiredArgsConstructor;
 import team.retum.jobis.common.annotation.ReadOnlyUseCase;
 import team.retum.jobis.common.spi.SecurityPort;
-import team.retum.jobis.domain.application.dto.response.QueryMyApplicationsResponse;
 import team.retum.jobis.domain.application.dto.ApplicationFilter;
+import team.retum.jobis.domain.application.dto.response.QueryMyApplicationsResponse;
 import team.retum.jobis.domain.application.spi.QueryApplicationPort;
 import team.retum.jobis.domain.application.spi.vo.ApplicationVO;
 import team.retum.jobis.domain.student.model.Student;
@@ -27,6 +27,6 @@ public QueryMyApplicationsResponse execute() {
 
         List<ApplicationVO> applicationVOs = queryApplicationPort.queryApplicationByConditions(applicationFilter);
 
-        return QueryMyApplicationsResponse.of(applicationVOs);
+        return QueryMyApplicationsResponse.from(applicationVOs);
     }
 }

jobis-application/src/main/java/team/retum/jobis/domain/application/usecase/QueryPassedApplicationStudentsUseCase.java

@@ -14,7 +14,7 @@ public class QueryPassedApplicationStudentsUseCase {
     public QueryPassedApplicationStudentsResponse execute(Long companyId) {
         return new QueryPassedApplicationStudentsResponse(
                 queryApplicationPort.queryPassedApplicationStudentsByCompanyId(companyId).stream()
-                        .map(QueryPassedApplicationStudentsResponse::of)
+                        .map(QueryPassedApplicationStudentsResponse::from)
                         .toList()
         );
     }

jobis-application/src/main/java/team/retum/jobis/domain/application/usecase/ReapplyUseCase.java

@@ -23,14 +23,13 @@ public void execute(Long applicationId, List<AttachmentRequest> attachmentReques
         Application application = queryApplicationPort.queryApplicationById(applicationId)
                 .orElseThrow(() -> ApplicationNotFoundException.EXCEPTION);
 
-        application.checkApplicationStatus(application.getApplicationStatus(), ApplicationStatus.REJECTED, ApplicationStatus.REQUESTED);
+        Application.checkApplicationStatus(
+                application.getApplicationStatus(),
+                ApplicationStatus.REJECTED, ApplicationStatus.REQUESTED
+        );
 
         commandApplicationPort.saveApplication(
-                application.reapply(
-                        attachmentRequests.stream()
-                                .map(attachment -> new ApplicationAttachment(attachment.url(), attachment.type()))
-                                .toList()
-                )
+                application.reapply(ApplicationAttachment.from(attachmentRequests))
         );
     }
-}
+}

jobis-application/src/main/java/team/retum/jobis/domain/application/usecase/TeacherQueryApplicationsUseCase.java

@@ -4,8 +4,8 @@
 import team.retum.jobis.common.annotation.ReadOnlyUseCase;
 import team.retum.jobis.common.dto.response.TotalPageCountResponse;
 import team.retum.jobis.common.util.NumberUtil;
-import team.retum.jobis.domain.application.dto.response.TeacherQueryApplicationsResponse;
 import team.retum.jobis.domain.application.dto.ApplicationFilter;
+import team.retum.jobis.domain.application.dto.response.TeacherQueryApplicationsResponse;
 import team.retum.jobis.domain.application.model.ApplicationStatus;
 import team.retum.jobis.domain.application.spi.QueryApplicationPort;
 import team.retum.jobis.domain.application.spi.vo.ApplicationVO;