🧩 :: (#482) 자잘한 수정

Team-return · Dec 5, 2023 · 5c654b5 · 5c654b5
1 parent 390f06c
commit 5c654b5
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 10 deletions.
diff --git a/jobis-application/src/main/java/team/retum/jobis/domain/student/spi/QueryStudentPort.java b/jobis-application/src/main/java/team/retum/jobis/domain/student/spi/QueryStudentPort.java
@@ -1,5 +1,6 @@
 package team.retum.jobis.domain.student.spi;
 
+import team.retum.jobis.domain.student.model.SchoolNumber;
 import team.retum.jobis.domain.student.model.Student;
 
 import java.util.Optional;
@@ -11,5 +12,5 @@ public interface QueryStudentPort {
 
     int queryStudentCountByGradeAndEntranceYear(int grade, int entranceYear);
 
-    boolean existsByGradeAndClassRoomAndNumberAndName(int grade, int classRoom, int number, String name);
+    boolean existsByGradeAndClassRoomAndNumberAndName(SchoolNumber schoolNumber, String name);
 }
diff --git a/...plication/src/main/java/team/retum/jobis/domain/student/usecase/VerifyStudentUseCase.java b/...plication/src/main/java/team/retum/jobis/domain/student/usecase/VerifyStudentUseCase.java
@@ -18,9 +18,7 @@ public class VerifyStudentUseCase {
     public void execute(String gcn, String name) {
         SchoolNumber parseSchoolNumber = SchoolNumber.parseSchoolNumber(gcn);
 
-        if (queryStudentPort.existsByGradeAndClassRoomAndNumberAndName(
-                parseSchoolNumber.getGrade(), parseSchoolNumber.getClassRoom(), parseSchoolNumber.getNumber(), name)
-        ) {
+        if (queryStudentPort.existsByGradeAndClassRoomAndNumberAndName(parseSchoolNumber, name)) {
             throw StudentAlreadyExistsException.EXCEPTION;
         }
 

diff --git a/...src/main/java/team/retum/jobis/domain/recruitment/presentation/RecruitmentWebAdapter.java b/...src/main/java/team/retum/jobis/domain/recruitment/presentation/RecruitmentWebAdapter.java
@@ -3,8 +3,6 @@
 import jakarta.validation.Valid;
 import jakarta.validation.constraints.Positive;
 import lombok.RequiredArgsConstructor;
-import org.springframework.cache.annotation.CacheConfig;
-import org.springframework.cache.annotation.Cacheable;
 import org.springframework.format.annotation.DateTimeFormat;
 import org.springframework.http.HttpStatus;
 import org.springframework.validation.annotation.Validated;
@@ -46,7 +44,6 @@
 import java.util.ArrayList;
 import java.util.List;
 
-@CacheConfig(cacheNames = "default")
 @RestController
 @Validated
 @RequiredArgsConstructor
@@ -98,7 +95,6 @@ public void createRecruitArea(
         createRecruitAreaUseCase.execute(webRequest.toDomainRequest(), recruitmentId);
     }
 
-    @Cacheable(key = "'all'")
     @GetMapping("/student")
     public StudentQueryRecruitmentsResponse studentQueryRecruitments(
             @RequestParam(value = "name", required = false) String companyName,

diff --git a/.../src/main/java/team/retum/jobis/domain/student/persistence/StudentPersistenceAdapter.java b/.../src/main/java/team/retum/jobis/domain/student/persistence/StudentPersistenceAdapter.java
@@ -2,6 +2,7 @@
 
 import lombok.RequiredArgsConstructor;
 import org.springframework.stereotype.Repository;
+import team.retum.jobis.domain.student.model.SchoolNumber;
 import team.retum.jobis.domain.student.model.Student;
 import team.retum.jobis.domain.student.persistence.mapper.StudentMapper;
 import team.retum.jobis.domain.student.persistence.repository.StudentJpaRepository;
@@ -33,8 +34,10 @@ public int queryStudentCountByGradeAndEntranceYear(int grade, int entranceYear)
     }
 
     @Override
-    public boolean existsByGradeAndClassRoomAndNumberAndName(int grade, int classRoom, int number, String name) {
-        return studentJpaRepository.existsByGradeAndClassRoomAndNumberAndName(grade, classRoom, number, name);
+    public boolean existsByGradeAndClassRoomAndNumberAndName(SchoolNumber schoolNumber, String name) {
+        return studentJpaRepository.existsByGradeAndClassRoomAndNumberAndName(
+                schoolNumber.getGrade(), schoolNumber.getClassRoom(), schoolNumber.getNumber(), name
+        );
     }
 
     @Override