Do not install the config folder in tm_driver #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`tm_driver` tries to install a non-existing `config` folder. This causes building the package in install mode to fail. Removed the install directive for that folder in the cmake file for the `tm_driver` package
|
@kentsai0319 Any feedback on this? Thank you |
|
@leoWuTmRobot I understand you're the current maintainer of this repo? Could you have a look at this? Thank you |
|
Dear Yuki:
According to our company’s policy, all questions should be reply to our proxy or sales and them can give you a reply.
If I didn’t get the replay from our proxy or sales, I don’t have any resource to add new feature or fix problem.
But about this problem, I can fix it on next commit within 3 week.
So, please wait a few days, once I finish this, I will info you.
From: Leo ***@***.***>
Sent: Friday, May 6, 2022 9:27 AM
To: TechmanRobotInc/tmr_ros1 ***@***.***>
Cc: leo.wu 吳如峰 ***@***.***>; Mention ***@***.***>
Subject: Re: [TechmanRobotInc/tmr_ros1] Do not install the config folder in tm_driver (#6)
@leoWuTmRobot<https://github.com/leoWuTmRobot> I understand you're the current maintainer of this repo? Could you have a look at this?
I'm happy to make any change that you see fit :)
Thank you
—
Reply to this email directly, view it on GitHub<#6 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ASOZE6FFFOMYSFHYRRE7KDDVIRYP5ANCNFSM4U7K6Z6Q>.
You are receiving this because you were mentioned.Message ID: ***@***.******@***.***>>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
When trying to integrate the ros package to an application build in install mode, the build for
tm_driverfailed because it could not install the non existentconfigfolder.Since the folder doesn't exist the install directive can safely be removed.