Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(select): fix select keys props has content not work #5199

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

fix(select): fix select keys props has content not work #5199

wants to merge 2 commits into from

Conversation

hello-ishine
Copy link

@hello-ishine hello-ishine commented Mar 19, 2025 •
edited by Wesley-0808
Loading

fix select keys props has content not work

closed #5088

🤔 这个 PR 的性质是？

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

#5088

💡 需求背景和解决方案

1.需要解决的问题
在Select 组件中使用 keys 属性时，如果使用了content 作为自定义字段名，会和内置 content 属性冲突，导致失效

2.解决办法
在解析 options 配置并且初始化innerOptions 的时候，去除掉自定义 keys 相关属性的透传

📝 更新日志

  • fix(Select): keys 属性配置 content 作为 value 时不生效问题

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项。⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

@hello-ishine
fix(select): fix select keys props has content not work
f044e56 
fix select keys props has content not work

closed Tencent#5088
@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Mar 20, 2025 •
edited
Loading

Open in Stackblitz

npm i https://pkg.pr.new/tdesign-vue-next@5199

commit: 592fbc0

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 20, 2025 •
edited
Loading

完成

@uyarn
Copy link
Collaborator

uyarn commented Mar 24, 2025

/update-snapshot

@github-actions GitHub Actions
Copy link
Contributor

⏳ 正在运行快照更新。。。 CI: Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PengYYYYY PengYYYYY Awaiting requested review from PengYYYYY PengYYYYY is a code owner

@chaishi chaishi Awaiting requested review from chaishi chaishi is a code owner

@xiaosansiji xiaosansiji Awaiting requested review from xiaosansiji xiaosansiji is a code owner

@honkinglin honkinglin Awaiting requested review from honkinglin honkinglin is a code owner

@LeeJim LeeJim Awaiting requested review from LeeJim LeeJim is a code owner

@uyarn uyarn Awaiting requested review from uyarn uyarn is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Select] keys属性配置content作为value时存在错误
2 participants
@hello-ishine @uyarn