Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Valid history strategy #196

Merged
merged 18 commits into from
Oct 28, 2024
Merged

Valid history strategy #196

merged 18 commits into from
Oct 28, 2024

Conversation

VarunSharma15
Copy link
Contributor

Description

This PR adds full support for valid_history incremental strategy.
This PR also contains test for valid history as a a full real-time project

Checklist

  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have updated the CHANGELOG.md with information about my change

@tallamohan
Copy link
Contributor

@VarunSharma15 , Can you please add an testcase/model with use_valid_to_time='yes'

tallamohan
tallamohan approved these changes Oct 28, 2024
View reviewed changes
Copy link
Contributor

@tallamohan tallamohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good

@VarunSharma15 VarunSharma15 merged commit 89f7cc7 into main Oct 28, 2024
4 checks passed
@VarunSharma15 VarunSharma15 deleted the valid_history_strategy branch October 28, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tallamohan tallamohan tallamohan approved these changes

@sc250072 sc250072 Awaiting requested review from sc250072

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@VarunSharma15 @tallamohan