adjustable number of output curve points in BSpline curves #1314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add number of output curve points in BSpline curves as parameter instead of a fixed number of 20. - add some checks in Nurbs::init() to prevent crashes in case the Nurbs surface is not well defined in the IFC model.
|
tests/ifcfiles/public/FM_ARC_DigitalHub.ifc- FAIL This model has failed a regression test. Can you manually open the model - confirm the changes are good and then run npm regression-update to update the dataset - and push the file to the PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add number of output curve points in BSpline curves as parameter instead of a fixed number of 20.
add some checks in Nurbs::init() to prevent crashes in case the Nurbs surface is not well defined in the IFC model.