Skip to content

refactor: MajorityElement #6380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 15, 2025

Conversation

alxkm
Copy link
Contributor

@alxkm alxkm commented Jul 13, 2025

Added null and empty input check to prevent unnecessary processing or NPEs.

Switched to interface type (Map) for better abstraction and flexibility.

Fixed JavaDoc to clarify behavior when input is null or empty.

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
  • All new code is formatted with clang-format -i --style=file path/to/your/file.java

@codecov-commenter
Copy link

codecov-commenter commented Jul 13, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 74.61%. Comparing base (287a708) to head (e7abf9c).

Files with missing lines Patch % Lines
...atastructures/hashmap/hashing/MajorityElement.java 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master    #6380   +/-   ##
=========================================
  Coverage     74.61%   74.61%           
- Complexity     5454     5456    +2     
=========================================
  Files           682      682           
  Lines         19009    19011    +2     
  Branches       3671     3671           
=========================================
+ Hits          14183    14186    +3     
+ Misses         4263     4262    -1     
  Partials        563      563           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@DenizAltunkapan DenizAltunkapan merged commit dcb02c6 into TheAlgorithms:master Jul 15, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants