Skip to content

refactor: Convolution #6382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 16, 2025
Merged

Conversation

alxkm
Copy link
Contributor

@alxkm alxkm commented Jul 13, 2025

Refactored the convolution method by replacing the while loop with a clearer for loop using explicit start and end indices for iteration, improving readability and reducing complexity.

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
  • All new code is formatted with clang-format -i --style=file path/to/your/file.java

@codecov-commenter
Copy link

codecov-commenter commented Jul 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.62%. Comparing base (d55e89d) to head (bf440d7).

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #6382   +/-   ##
=========================================
  Coverage     74.62%   74.62%           
  Complexity     5453     5453           
=========================================
  Files           682      682           
  Lines         19009    19010    +1     
  Branches       3670     3670           
=========================================
+ Hits          14185    14187    +2     
  Misses         4261     4261           
+ Partials        563      562    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@DenizAltunkapan DenizAltunkapan enabled auto-merge (squash) July 16, 2025 15:02
@DenizAltunkapan DenizAltunkapan merged commit 434ab50 into TheAlgorithms:master Jul 16, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants