TINY-7416: Turn on all warnings except 105, and fix the problems that…

… highlights. Reformat code.
TheSpyder · May 31, 2021 · efda3d2 · efda3d2
1 parent 0cd2244
commit efda3d2
Show file tree

Hide file tree

Showing 6 changed files with 26 additions and 20 deletions.
diff --git a/bsconfig.json b/bsconfig.json
@@ -17,8 +17,8 @@
     }
   ],
   "warnings": {
-    "number": "+A-42-48-105-109",
-    "error": "+A-3-44-102"
+    "number": "+A-105",
+    "error": "+A"
   },
   "bs-dependencies": [
     "bs-fetch"

diff --git a/examples/dom_example.re b/examples/dom_example.re
@@ -11,9 +11,10 @@ let unwrapUnsafely =
 /*
  * These SHOULD type check
  */
-document->Document.createElement("div")->Element.className;
+let _ = document->Document.createElement("div")->Element.className;
 
-document->Document.createElement("div")->Element.nextElementSibling->map(Element.innerText); /* innerText is a function that accepts a Node */
+let _ =
+  document->Document.createElement("div")->Element.nextElementSibling->map(Element.innerText); /* innerText is a function that accepts a Node */
 
 /* Before subtyping:
    document -> Document.createElement("div")
@@ -23,10 +24,11 @@ document->Document.createElement("div")->Element.nextElementSibling->map(Element
    */
 
 /* After subtyping: */
-document
-->Document.createElement("div")
-->Element.parentElement /* inherited from Node, returns DomRe.element */
-->map(Element.innerText); /* inherited from Node */
+let _ =
+  document
+  ->Document.createElement("div")
+  ->Element.parentElement /* inherited from Node, returns DomRe.element */
+  ->map(Element.innerText); /* inherited from Node */
 
 let el = document->Document.createElement("div")->Element.asHtmlElement->unwrapUnsafely;
 
@@ -43,10 +45,11 @@ let el = document->Document.createElement("div")->Element.asHtmlElement->unwrapU
    */
 
 /* After subtyping: */
-document
-->Document.asHtmlDocument
-->flatMap(HtmlDocument.body)
-->map(body => body->Element.appendChild(el));
+let _ =
+  document
+  ->Document.asHtmlDocument
+  ->flatMap(HtmlDocument.body)
+  ->map(body => body->Element.appendChild(el));
 
 /*
  /*

diff --git a/src/Webapi/Canvas/Webapi__Canvas__Canvas2d.re b/src/Webapi/Canvas/Webapi__Canvas__Canvas2d.re
@@ -191,8 +191,10 @@ external arc:
 [@set] external font: (t, string) => unit;
 [@set] external textAlign: (t, string) => unit;
 [@set] external textBaseline: (t, string) => unit;
-[@send] external fillText: (t, string, ~x: float, ~y: float, ~maxWidth: float=?, [@ignore] unit) => unit;
-[@send] external strokeText: (t, string, ~x: float, ~y: float, ~maxWidth: float=?, [@ignore] unit) => unit;
+[@send]
+external fillText: (t, string, ~x: float, ~y: float, ~maxWidth: float=?, [@ignore] unit) => unit;
+[@send]
+external strokeText: (t, string, ~x: float, ~y: float, ~maxWidth: float=?, [@ignore] unit) => unit;
 [@send] external measureText: (t, string) => measureText;
 [@get] external width: measureText => float;
 

diff --git a/tests/Webapi/Canvas/Webapi__Canvas__Canvas2d__test.re b/tests/Webapi/Canvas/Webapi__Canvas__Canvas2d__test.re
@@ -70,11 +70,11 @@ let width = width(measureText);
 ctx->fillText("foo!", ~x=0.0, ~y=0.0, ~maxWidth=width, ());
 ctx->strokeText("foo!", ~x=0.0, ~y=0.0, ~maxWidth=width, ());
 let imageData = createImageDataCoords(ctx, ~width=0.0, ~height=0.0);
-createImageDataFromImage(ctx, imageData);
-Image.width(imageData);
-Image.height(imageData);
+let _ = createImageDataFromImage(ctx, imageData);
+let _ = Image.width(imageData);
+let _ = Image.height(imageData);
 
-getImageData(ctx, ~sx=0.0, ~sy=0.0, ~sw=0.0, ~sh=0.0);
+let _ = getImageData(ctx, ~sx=0.0, ~sy=0.0, ~sw=0.0, ~sh=0.0);
 let _: unit = putImageData(ctx, ~imageData, ~dx=0.0, ~dy=0.0);
 let _: unit =
   putImageDataWithDirtyRect(

diff --git a/tests/Webapi/Dom/Webapi__Dom__EventTarget__test.re b/tests/Webapi/Dom/Webapi__Dom__EventTarget__test.re
@@ -27,4 +27,4 @@ let customEvent = CustomEvent.makeWithOptions("custom-event", {
                                                                   "test": "test",
                                                                 },
                                                               });
-target->dispatchEvent(customEvent);
+let _ = target->dispatchEvent(customEvent);
diff --git a/tests/Webapi/Dom/Webapi__Dom__Window__test.re b/tests/Webapi/Dom/Webapi__Dom__Window__test.re
@@ -58,7 +58,8 @@ let _ = Window.getSelection(window);
 let _ = window->Window.matchMedia("max-height: 400");
 let _ = window->Window.moveBy(10, -10);
 let _ = window->Window.moveTo(120, 300);
-let _: option(Dom.window) = window->Window.open_(~url="http://...", ~name="my window", ~features="menubar=yes" ,());
+let _: option(Dom.window) =
+  window->Window.open_(~url="http://...", ~name="my window", ~features="menubar=yes", ());
 let _: option(Dom.window) = window->Window.open_(~url="http://...", ~name="my window", ());
 window->Window.postMessage("my message", "*");
 Window.print(window);