-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Fetch support directly into the fork #5
Comments
When we do this, add Abortable fetch is available in all modern browsers. |
This is now very high priority - ReScript 10 is dropping |
Apparently I just wasn't paying attention... Although to be fair while the type is defined it's not available for use 🤔 |
Fix is in progress |
As much as I'd like to update the API, there are over 1300 repositories depending on I do have plenty of ideas for ways the API can be improved - logged #30 to work on them. If I have time for both the API update and a migration guide before ReScript 10 is released we can consider merging it. |
Released in 0.1.3 |
This library currently depends on https://github.com/reasonml-community/bs-fetch but unlike JS packages ReScript dependencies aren't automatic. In order to compile with ReScript
bs-fetch
must be added to the top levelbsconfig.json
of projects that want to start usingrescript-webapi
, even if the parts that depend onbs-fetch
are never used. This is an annoyance I'd rather avoid.The licenses are compatible, we can just pull it in and apply similar improvements to what we're planning here (looks like there are some records-as-objects opportunities).
The text was updated successfully, but these errors were encountered: