Switch to pipe-first #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rebased with test diffs
…as waiting on a bugfix... merged in 2017
… highlights. Reformat code.
spocke
approved these changes
Jun 3, 2021
yawaramin
reviewed
Jun 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6
I took the opportunity to remove all
@bsprefixed decorators. I'm sure that will be necessary at some point. I also appliedrefmtbecause... well so much is changing already we might as well. So be sure to turn on 'hide whitespace changes' in the diff.I restored a bunch of old tests directly on
main, so the diff includes all the JS generated code updates.During this process I came across some commented out code in
Canvas__Canvas2dthat was waiting on a bugfix... merged in 2017. So I've reactivated it and that turns a couple of methods into zero cost.