Add response constructors #64
Conversation
| @@ -6,6 +6,7 @@ type body | |||
| type bodyInit | |||
| type headers | |||
| type headersInit | |||
| type responseInit | |||
There was a problem hiding this comment.
I wasn't sure if I should add alias the types from the top level or not as it says they are here for compatibility purposes. Let me know if I should remove them 👍
There was a problem hiding this comment.
This is fine. We can re-evaluate these for the eventual rewrite of the bindings.
There was a problem hiding this comment.
Looks good.
I wonder why the Response methods were not wrapped in decoders while the Request methods were 🤔 since we're updating it anyway, can you please add one for Response.type_ so it matches what happens with Request.type_? I don't think any of the others need a decoder.
[edit] I was wrong, see below
| @@ -6,6 +6,7 @@ type body | |||
| type bodyInit | |||
| type headers | |||
| type headersInit | |||
| type responseInit | |||
There was a problem hiding this comment.
This is fine. We can re-evaluate these for the eventual rewrite of the bindings.
|
Oh I just read your other PR 🤣 [edit] never mind response type is an entirely different concept, I should read the specs before commenting... |
|
I forgot to ask for a changelog, but I'll add it before publishing the release |
|
Published as 0.3.0 |
Closes #63