The master branch is becoming the main development branch #1153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fix missing tests for make_action_button
- possible bugfix for make_action_button
- check with grepl instead of grep to avoid numeric(0) in
if-statement which would make the corresponding test fail
for button_6: class attribute present but not equal to
"action-button" gives an error
- fix missing test for undisplay
- add missing tests for rv and rvtl
1. add a double check to look for modules with names starting with "mod_mod_xxx" (see R/add_r_files.R) 2. add syntax check for module names to add_module(): explicitly ask the user if s/he wants to name her module "mod_xxx" or "mod_mod_xxx"
- save old golem name in tmp-variable and use helper-func inside set_golem_name() to overwrite tests/testthat.R - helper-func screens for old_name instances and replaces them with new_name Refs: #805
- save <old_name> in tmp-variable and use helper-func inside set_golem_name() to change file name from "vignettes/<old_name>.R" to "vignettes/<new_name>.R" - helper-func screens for old_name instances inside <vignettes/<old_name>.R> and replaces them with new_name, then saves output to "vignettes/<new_name>.R" Refs: #805
- adding a message to the user to check for other places for the name - passing the path to sub functions
- remove 'author_XXX' args and replace with 'authors' - make 'authors' arg default to class 'person' - use class check on 'authors', throw error if it fails - use desc$set_authors This mostly draws from the ideas of @jmeyer2482 and @ColinFay: Co-authored-by: Colin Fay <[email protected]> Co-authored-by: jmeyer2482 <[email protected]>
- update vignette/a_start.Rmd with new fill_desc() interface - delete some redundant whitespaces in same file
- changes since values of authors are of type person() which
requires parsing the entries
- adjust interace of fill_desc() so build.R runs smoothly
This reverts commit ac237d5.
- remove warning due "Undocumented arguments in documentation object" in fill_desc - add forgotten @importFrom utils person that caused a note
- devtools::build_readme() cannot be run when aut/cre is missing
- add_rscignore_file() generates .rscignore at golem top level - call in add_rstudio_files() is used in RStudio connect, shiny server and shinyapps io - can be called directly Refs: #110
- fix typos in two tests - update docs to pass CI - use different cat_green_tick() for app.R and .rscignore as they are called right after each other - move doc for rscignore down so man-page displays add_rstudioconnect_file at the top
* feat `golem::add_dockerfile_with_renv_*()` set "rstudio" as default USER in Dockerfile to avoid launching app as root * feat It is now easier to modify the renv.config.pak.enabled parameter in the Dockerfile generated by golem::add_dockerfile_with_renv_*().
|
Here is the workflow that we'll try to follow :
That way, we'll keep the main branch stable, but it won't necessarily mean that merge to main == release to CRAN |
ColinFay
changed the title
ColinFay
changed the title
|
I'll close and reopen a PR so that it's clearer in the git history |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The master branch is becoming the main development branch. This will allow users to perform remotes::install_github("thinkr-open/golem") with the up-to-date development version without having to do remotes::install_github("thinkr-open/golem@dev"). Currently, the master branch is a copy of the CRAN version, which is of little interest. Instead, let's use the concept of release to fix what has been submitted to CRAN."
ok @ColinFay ?