Increase queueing capacity #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Originally only one batch could be queued up at a time. If the available processing concurrency is e.g. 10 batches of 10 items, then the worst case is that all batches finish at the same time and we only have 10 new items to process, using only 10% of the available capacity. If we can queue up the same number of items as we can process, then we would be able to use 100% of the processing capacity in this case. To that end, we now queue multiple batches ready for processing, instead of just one.
ThomWright
force-pushed
the
increase-queueing-capacity
branch
from
1225ca6 to
60a4ac2
Compare
tokio-rs/tracing#2874 Looks like a bug in tracing is making the tests flaky.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally only one batch could be queued up at a time.
If the available processing concurrency is e.g. 10 batches of 10 items,
then the worst case is that all batches finish at the same time and we
only have 10 new items to process, using only 10% of the available
capacity.
If we can queue up the same number of items as we can process, then we
would be able to use 100% of the processing capacity in this case.
To that end, we now queue multiple batches ready for processing, instead
of just one.