-
Notifications
You must be signed in to change notification settings - Fork 0
update v1 endpoints to use carrara #37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
st4tdb
wants to merge
17
commits into
master
Choose a base branch
from
st4tdb/update_endpoints
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 6 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
98ff47a
use new openapiv1
DimitrisStaratzis 1f39345
refresh with new spec
DimitrisStaratzis a8f1f04
update examples
DimitrisStaratzis 51e26ff
use snapshot for pre-release version
DimitrisStaratzis 05a74c0
fix FILES and remove some wrong checks
DimitrisStaratzis 45e0da0
fix doc packages
DimitrisStaratzis 4f28520
Bump version to `1.0.0-SNAPSHOT`
ryan-williams fb78976
Add `regen.sh`, `DEVELOP.md`, `config.yaml`, `openapitools.json` (pin…
ryan-williams 32d70c5
Update `openapi-v1.yaml`
ryan-williams 03e3dc5
`openapi-generator-cli generate -i openapi-v1.yaml -g java -c config.…
ryan-williams 38594bb
CustomCode, workspace patches
ryan-williams 1f076eb
rm `TileDB{SQL,UDF}.java`, `update Examples.java`
ryan-williams 96bc623
Left-merge `st4tdb/update_endpoints`
ryan-williams 78044df
Merge pull request #38 from TileDB-Inc/rw/37
ryan-williams 6b44121
`Examples.java`: rm duplicated block
ryan-williams 174b2fd
remove bad checks part1
DimitrisStaratzis fc97b7b
remove bad checks part2
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
7.7.0 | ||
6.0.1 | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -37,5 +37,7 @@ | |
|
||
* `READ_ENUMERATIONS` (value: `"read_enumerations"`) | ||
|
||
* `NEXTFLOW` (value: `"nextflow"`) | ||
|
||
|
||
|
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be good to use the same version, to rule out spurious diffs introduced by a changed version.
Looks like 7.12.0 is latest, atm, but I'd suggest changing the version as a separate PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch. I think it is better if we use the latest version in a separate PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about just using the same version that was previously used? (7.7.0)
Just trying to rule out introducing spurious changes from going backwards on the version here.