Skip to content

Scripts for regenerating client #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 16, 2025
Merged

Conversation

ryan-williams
Copy link
Member

@ryan-williams ryan-williams commented May 16, 2025

This is a parallel-construction of #37, including:

  • regen.sh: regenerates the client, applies "custom code" changes (see the commit pointed to by branch patch), commits to Git
    • Can be run on this branch idempotently (results in no additional changes)
  • Use [email protected] (matching the previous version, and undoing some unnecessary diffs from update v1 endpoints to use carrara #37)
  • DEVELOP.md documents how to update openapi-v1.yaml, and run regen.sh.

See here for a direct comparison of this branch vs. master: master...rw/37

Total diff vs. master is significantly reduced; before (#37):
Screenshot 2025-05-15 at 9 40 32 PM
After (this PR):
Screenshot 2025-05-16 at 12 40 18 AM

Update local copy of spec from [`TileDB-Server//openapi/v1to3/src/openapi-v1.yaml`](https://github.com/TileDB-Inc/TileDB-Server/blob/main/openapi/v1to3/src/openapi-v1.yaml):
```bash
gh api \
  -H "Accept: application/vnd.github.raw" \
   /repos/TileDB-Inc/TileDB-Server/contents/openapi/v1to3/src/openapi-v1.yaml \
> openapi-v1.yaml
```
@ryan-williams ryan-williams requested a review from st4tdb May 16, 2025 05:04
@ryan-williams ryan-williams merged commit 78044df into st4tdb/update_endpoints May 16, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants