Pass reader to ImageConverter.to_tiledb() instead of creating custom ImageConverter subclasses #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ImageConverter subclasses
gsakkis
force-pushed
the
gsa/pass-ImageReaders
branch
from
193745b to
adb5c0d
Compare
…ImageConverter subclasses
…tiledb-bioimg into gsa/pass-ImageReaders
ihnorton
force-pushed
the
main
branch
2 times, most recently
from
52b615e to
6dac1e6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drop dummy
ImageConvertersubclasses, pass theImageReaderdirectly toImageConverter.to_tiledb().Should be merged after TileDB-Inc/TileDB-BioImaging#75
[Upd] Currently we enforce a check of the Reader class to match converter in
tiledb-bioimgso to avoid frankenstein expressions as commented here. This will not allow this PR to be merged even though #75 is already merged. Moving it to Draft for now.