Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raise errors and not warnings #13

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Raise errors and not warnings #13

wants to merge 3 commits into from

Conversation

ktsitsi
Copy link
Contributor

@ktsitsi ktsitsi commented May 23, 2023

This PR:

  • raises Errors in case of failed conditions and not warning.warn. The latter implementation was logging the errors at the top and this was affecting readability.

@shortcut-integration
Copy link

This pull request has been linked to Shortcut Story #28950: [napari] Check for path validity, and raise a better error if not valid.

@ktsitsi ktsitsi requested a review from ihnorton May 23, 2023 12:36
ihnorton
ihnorton reviewed May 23, 2023
View reviewed changes
Copy link
Member

@ihnorton ihnorton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is doing any checks for path validity?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ihnorton ihnorton ihnorton left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ktsitsi @ihnorton