ADF-29 | misc. settings #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
TinyTakinTeller
commented
Jul 11, 2024
•
TinyTakinTeller
commented
TinyTakinTeller
changed the title
TinyTakinTeller
force-pushed
the
ADF-29-misc-settings
branch
from
fc3aacc to
5ccc28d
Compare
TinyTakinTeller
force-pushed
the
ADF-29-misc-settings
branch
from
62b6b8f to
5aa9f3b
Compare
TinyTakinTeller
commented
Jul 13, 2024
|
|
||
| display_mode_button.text = "?" | ||
| display_resolution_button.text = "?" | ||
| ## TODO: replace resolution setting with a different one |
There was a problem hiding this comment.
supporting "resolution" setting for this kind of game seems unnecessary right now
(for web game, having a toggle between window and fullscreen seems sufficient ?)
i'm open to ideas for another toggle setting here
mielifica
approved these changes
Jul 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.