ADF 41 | gdlint github action #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a gdlint github action, with variable problems threshold
Mainly copied this file: https://github.com/GodotVR/godot-xr-tools/blob/master/.github/workflows/gdlint-on-push.yml
And then added a step to compare with the threshold
About the threshold
I think it could be useful, because there may be situations where you introduce a linter problem, but it's not something you want to fix now. So then you can increase the threshold and still merge (without "hiding" the problem by adding an ignore statement in the code)
To test
You can check the action that ran on this PR.
You can also test github actions locally by installing
act: https://github.com/nektos/act/releases (you'll also need docker installed)In the root directory run: