Skip to content

Reads attributes from exr header and display them in a window #243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Wagyx
Copy link

@Wagyx Wagyx commented Nov 17, 2024

Hello,
I have added a way to retrieve the EXR attributes from the file header and display them with a new info button that pops up a window. (like the help button).
I have struggled a bit with the window layout, it is not great.
Also if you change the current image when the window is enabled, the info is not updated. It reloads if you hide and show it again with the info button though.
I was thinking that maybe other information such as EXIF metadata could be added to it at some point.

@Tom94
Copy link
Owner

Tom94 commented Nov 18, 2024

Hi there, thanks for the contribution!

Like you already say, the UX needs some improvement for the feature to be merged, like the window automatically updating when the image changes.

I also spot a few minor issues with the code that should get fixed along the way. Some examples:

  • Inconsistent formatting (I see places with missing spaces, wrong indentation, braces on separate lines where the rest of the codebase puts them on the same, etc.)
  • Code duplication (the metadata window seems to share some parts with the help window which should be suitably abstracted out)
  • Some public-facing data members (should be getters/setters)

Thanks again!

@Wagyx
Copy link
Author

Wagyx commented Nov 20, 2024

Thank you for the feedback. I'll work on those items.
What formatter do you recommend I use ? My IDE is VSCode and the default one was inconsistent with your formatting.

@Wagyx
Copy link
Author

Wagyx commented Dec 1, 2024

I have improved the display of the attributes and the window now updates when changing the selected image.

@KaoCC
Copy link

KaoCC commented Mar 21, 2025

I just stumble upon this PR when cloning this repo and can comment a bit.

What formatter do you recommend I use ? My IDE is VSCode and the default one was inconsistent with your formatting.

In the project folder, there is a clang-format definition:
https://github.com/Tom94/tev/blob/master/.clang-format

In VSCode, you can configure it to reference this file for formatting your source code, ensuring that your code maintains a consistent style with the rest of the project.

More information can be found in here:
https://code.visualstudio.com/docs/cpp/cpp-ide

See "Code formatting"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants