Avoid reporting error on Findbugs empty review #82
+6
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think your solution is cleaner than what we have right now. Can you please update your pull request to current master? Thanks. |
|
Sure, no problem. Take a look and see if this is what you're after. There are a couple failed tests but it looks like they're also failed on master. |
SpOOnman
added a commit
that referenced
this pull request
Mar 31, 2015
Avoid reporting error on Findbugs empty review
|
Thanks. These tests fail, but I merge your PR and fix them afterwards. |
rufuslevi
pushed a commit
to rufuslevi/sputnik
that referenced
this pull request
Mar 12, 2024
Avoid reporting error on Findbugs empty review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Also see #69)
The change to global problems collection (75b30e1) caused Sputnik to report a problem in cases where FindBugs had no files to check, because FindBugs by default throws IOException in that case. Since FindBugs only checks Java files, this can occur if a commit or pull request includes changes to build files, properties files, or documentation, which does not seem like an error condition.
The previous revision of the FindBugs processor swallowed IOException in this case. Fortunately, FindBugs has a flag that can be set to avoid the exception instead, which is a little cleaner. The result is an empty review.