Break down fee calculator interfaces #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The pool contract needs to estimate the fee to charge for a deposit or redemption separately from executing the distribution of the total fee to the fee recipients because in between the two the pool contract needs to either burn the tokens from the user in case of a redemption or mint tokens to the user in case of a deposit. In order to best facilitate this requirement the current fee calculator interface needs to separate estimating the fee of a deposit/redemption from estimating the shares for each fee recipient.
0xmichalis
force-pushed
the
refactor-interfaces
branch
from
d4cf262 to
99f19a4
Compare
PawelTroka
approved these changes
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pool contract needs to estimate the fee
to charge for a deposit or redemption separately
from executing the distribution of the total fee
to the fee recipients because in between the two
the pool contract needs to either burn the tokens
from the user in case of a redemption or mint tokens
to the user in case of a deposit.
In order to best facilitate this requirement the
current fee calculator interface needs to separate
estimating the fee of a deposit/redemption from
estimating the shares for each fee recipient.