Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: FlatFeeCalculator #52

Merged
merged 5 commits into from
Apr 23, 2024
Merged

feat: FlatFeeCalculator #52

merged 5 commits into from
Apr 23, 2024

Conversation

kosecki123
Copy link
Contributor

@kosecki123 kosecki123 commented Apr 23, 2024 •
edited
Loading

This PR add simple basis points flat fee calculator module compatible with IFeeCalculator interface.

Additional function for owner purpose:

function setFeeBasisPoints(uint256 _feeBasisPoints) external onlyOwner

@kosecki123 kosecki123 marked this pull request as ready for review April 23, 2024 10:32
0xmichalis
0xmichalis previously approved these changes Apr 23, 2024
View reviewed changes
Copy link
Member

@0xmichalis 0xmichalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0xmichalis
Copy link
Member

Seems formatting is failing

@0xmichalis 0xmichalis merged commit 12ad5fc into ToucanProtocol:main Apr 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xmichalis 0xmichalis 0xmichalis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kosecki123 @0xmichalis